New issue
Advanced search Search tips

Issue 866037 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 25
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

potential Jank caused by RenderWidgetHostImpl::OnStartDragging

Project Member Reported by etienneb@chromium.org, Jul 20

Issue description


Slow-reports is shipped back to our server with a chrome trace when some jank is detected on the chrome main thread.

In some case, the jank seems to be multiple seconds. See attachment.

Slow-reports (crash server)
    38b24142f4540d03    windows    69.0.3486.0    12 sec
    05a5695d2dab9c05    windows    67.0.3371.0    10 sec
    a4dd5b53755509a6    windows    69.0.3495.0     3 sec

The culprit function is DragHostMsg_StartDragging.

This is pointing to this code:
  https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?type=cs&sq=package:chromium&g=0&l=1810


My hypothesis is that some expensive computation is hidden behind
  1) for (const auto& file_info : drop_data.filenames) {
  2) for (size_t i = 0; i < drop_data.file_system_files.size(); ++i) {


 
jank.png
27.1 KB View Download
Description: Show this description
Description: Show this description
Labels: Hotlist-Jank
Actually, from the sampling profiler it looks like the OS is entering a nested loop :

https://uma.googleplex.com/p/chrome/callstacks?sid=95ab2ebf37624b2586c1663f9fa2c26f

WAI?
I was able to repro locally, with more tracing categories activated.
See attachments.
trace_Fri_Jul_20_2018_3.58.51_PM.json.gz
894 KB Download
jank2.png
44.9 KB View Download
Status: WontFix (was: Untriaged)
I believe this is WAI.
It seems there is an inner tasks running queue.

Sign in to add a comment