Add new builder for Chrome for Android incremental build/test |
|||
Issue descriptionOS: Android This is a request to set up a new builder/tester for the incremental builds for Chrome for Android. The incremental build is sometimes broken, and we want to have an early warning system for when this happens, instead of developers finding it out after a while on their own. We want to build the incremental target, and then run a very simple test, basically just start up Chrome and see if it loads successfully, using the incremental test framework. That way we get to test both the main APK and the test APK to see that it works.
,
Jul 20
not really. nyquist and I talked about this earlier this week; I'll handle setting this up.
,
Aug 17
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/5c109dacc307806798f425554fbfe26e43c3aecf commit 5c109dacc307806798f425554fbfe26e43c3aecf Author: John Budorick <jbudorick@google.com> Date: Fri Aug 17 21:55:43 2018
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/0b083815f4402247e3eccd69591139dd073456fa commit 0b083815f4402247e3eccd69591139dd073456fa Author: John Budorick <jbudorick@chromium.org> Date: Fri Aug 17 22:18:42 2018 Recipe configuration for android-incremental-dbg. Bug: 866032 Change-Id: I7296e35725a62cc7811117411e9977a0c38a8f0e Reviewed-on: https://chromium-review.googlesource.com/1180348 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/0b083815f4402247e3eccd69591139dd073456fa/scripts/slave/recipe_modules/chromium_tests/chromium_android.py [modify] https://crrev.com/0b083815f4402247e3eccd69591139dd073456fa/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py [modify] https://crrev.com/0b083815f4402247e3eccd69591139dd073456fa/scripts/slave/gatekeeper.json
,
Aug 17
What gn arguments should be set for the builder? debug + enable_incremental_javac + incremental_apk_by_default?
,
Aug 17
agrieve: I think you'd know better than me what would be helpful here. Also, which targets should we test? I was thinking something like the absolute smallest of smoke tests. Maybe just a handful of actual tests?
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83e7387a69090bec8721af534552a8ed9f80d505 commit 83e7387a69090bec8721af534552a8ed9f80d505 Author: John Budorick <jbudorick@chromium.org> Date: Tue Aug 21 17:15:46 2018 Add luci, compile, and test configs for android-incremental-dbg. Bug: 866032 Change-Id: I1ae69024219ab6c730d5995914af68b64c89910c Reviewed-on: https://chromium-review.googlesource.com/1180483 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584803} [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/infra/config/global/cr-buildbucket.cfg [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/infra/config/global/luci-milo.cfg [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/infra/config/global/luci-scheduler.cfg [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/testing/buildbot/chromium.android.json [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/testing/buildbot/test_suites.pyl [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/83e7387a69090bec8721af534552a8ed9f80d505/tools/mb/mb_config.pyl
,
Aug 21
bot is running over at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-incremental-dbg. I expect there to be a few issues to iron out before marking this fixed.
,
Aug 22
agrieve: Do you think you could take a look at the build failures?
,
Aug 24
Looks like the issue is an incomplete swarming isolate: IOError: [Errno 2] No such file or directory: '/b/swarming/w/ir/out/Debug/gen/base/base_unittests_apk.incremental.json'
,
Aug 24
I do intend to continue fiddling with this; we've had a busy week in infra land, though.
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/661c170c7a029cf1ad9faf0438213e3e08198d36 commit 661c170c7a029cf1ad9faf0438213e3e08198d36 Author: John Budorick <jbudorick@chromium.org> Date: Mon Aug 27 17:08:34 2018 android: keep *.incremental.json as a runtime dependency. Bug: 866032 Change-Id: I0f88b10009042901a11adfff40302f830854cad9 Reviewed-on: https://chromium-review.googlesource.com/1189132 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#586288} [modify] https://crrev.com/661c170c7a029cf1ad9faf0438213e3e08198d36/build/config/android/rules.gni
,
Aug 28
incremental builds need quite a few more things at runtime; working through the gn changes required. |
|||
►
Sign in to add a comment |
|||
Comment 1 by jbudorick@chromium.org
, Jul 20