New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865993 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Update Team Drives icon

Project Member Reported by mcirimele@chromium.org, Jul 20

Issue description

I'd like to update the icon for drives on the first level under "Team Drives" to the regular Drive icon (without people on it).

Weifang, please let me know what milestone we can target this for and I'll loop in an available visual designer to prepare the assets.
 
Cc: sgabr...@chromium.org
I found the assets, attaching here. 
Let me know if you have any questions!

ccing Sebastien as an FYI
hard_drive_active.png
315 bytes View Download
hard_drive.png
298 bytes View Download
hard_drive_active.png
546 bytes View Download
hard_drive.png
549 bytes View Download
Cc: -slangley@chromium.org weifangsun@chromium.org
Owner: slangley@chromium.org
Status: Assigned (was: Untriaged)
slangley@ - I think it would be good to get this in M69 to close out the Team Drives feature. I think this is an asset swap, but let me know if it's a higher effort than I think.
Owner: lucmult@chromium.org
Luciano - can you make this change, seems quick?

I see there's already assets called hard_drive.png and hard_drive_active.png, so wonder if we just re-use them?
Status: Started (was: Assigned)
Yes, it's pretty quick, but I'm not 100% sure if I got it right, we have the "Team Drives" root and each individual "team drive" underneath it.

Do we want all of them changed, just the top root or only the individual team drive?

See attached the 3 different options in screenshots.
root.png
63.0 KB View Download
both.png
31.0 KB View Download
individual_team_drives.png
36.5 KB View Download
Thanks for the screenshots lucmult@! The change we are looking for is the "root.png" image. The "Team Drives" root should have the people on it, and then individual team drives under the root should have the icon in this bug with no people.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce8ad1cf5067d0a160c6deeef7dfd9d56bb38e0

commit 8ce8ad1cf5067d0a160c6deeef7dfd9d56bb38e0
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Jul 31 03:31:15 2018

Update Team Drive icons

Change icons for each team drive in the directory tree and on file list
(RHS).

Bug:  865993 
Change-Id: If880279f9776ff70b33d13ec02aaeb5d4ce44290
Reviewed-on: https://chromium-review.googlesource.com/1155282
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579304}
[modify] https://crrev.com/8ce8ad1cf5067d0a160c6deeef7dfd9d56bb38e0/ui/file_manager/file_manager/foreground/css/file_types.css

Labels: Merge-Request-69
This is a CSS change to update icon for a new feature in M69, I've tested locally and screenshot is provided above.

Requesting to merge on M-69 branch.
Pls apply appropriate OSs label. 
Labels: OS-Chrome
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 1

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35963fe0fdaef2ea1cb17aecddbc103bde67423d

commit 35963fe0fdaef2ea1cb17aecddbc103bde67423d
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Aug 01 04:06:23 2018

Update Team Drive icons

Change icons for each team drive in the directory tree and on file list
(RHS).

Bug:  865993 
Change-Id: If880279f9776ff70b33d13ec02aaeb5d4ce44290
Reviewed-on: https://chromium-review.googlesource.com/1155282
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579304}(cherry picked from commit 8ce8ad1cf5067d0a160c6deeef7dfd9d56bb38e0)
Reviewed-on: https://chromium-review.googlesource.com/1157984
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#306}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/35963fe0fdaef2ea1cb17aecddbc103bde67423d/ui/file_manager/file_manager/foreground/css/file_types.css

Status: Fixed (was: Started)

Sign in to add a comment