New tab created from tab grid doesn't match NTP during animation |
||||||||||
Issue descriptionWhen creating a new (non-incognito) tab from the tab grid, one of the following happens: (A) There's no snapshot for the new tab, so the expanding tab is mostly blank until the animation ends, when it becomes abruptly an NTP. or, (B) There is an NTP snapshot for the animation, but the fakebox text layout doesn't exactly match that of the final NTP, so as the animation completes, there's a jump as the real NTP is shown.
,
Jul 20
,
Jul 20
Related to "[iOS] Updated foreground new-tab animation for UIRefresh" https://chromium-review.googlesource.com/1143394
,
Jul 24
,
Jul 24
Issue 867046 has been merged into this issue.
,
Jul 28
,
Jul 30
Issue 868096 has been merged into this issue.
,
Jul 31
Issue 868291 has been merged into this issue.
,
Jul 31
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69e4263a35e7b987052183cfbbce719287129483 commit 69e4263a35e7b987052183cfbbce719287129483 Author: Mark Cogan <marq@google.com> Date: Tue Jul 31 17:50:48 2018 [iOS] Use NTP snapshot in new tab animation from grid. New tabs opened from the grid were shown as white as they animated open, because they were only showing the cell's snapshot, not the snapshot taken from the BVC that will be displayed. This was because the gird animation only shows the BVC snapshot if it thinks there will be a difference between it and the cell snapshot -- specifically when there's been a device rotation. This CL lets the grid view controller flag the active cell in the animation as "appearing" so that the animation can always show the BVC's snapshot in that case. Bug: 865978 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iede4af004e89e5fda1395c4257c3d74fd2a682c7 Reviewed-on: https://chromium-review.googlesource.com/1156685 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579470} [modify] https://crrev.com/69e4263a35e7b987052183cfbbce719287129483/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/69e4263a35e7b987052183cfbbce719287129483/ios/chrome/browser/ui/tab_grid/transitions/grid_to_visible_tab_animator.mm [modify] https://crrev.com/69e4263a35e7b987052183cfbbce719287129483/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm [modify] https://crrev.com/69e4263a35e7b987052183cfbbce719287129483/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_layout.h [modify] https://crrev.com/69e4263a35e7b987052183cfbbce719287129483/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_layout.mm
,
Jul 31
,
Aug 1
Verified on canary 70.0.3509.0.
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255 commit 242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255 Author: Mark Cogan <marq@google.com> Date: Thu Aug 02 07:35:59 2018 [iOS] Use NTP snapshot in new tab animation from grid. New tabs opened from the grid were shown as white as they animated open, because they were only showing the cell's snapshot, not the snapshot taken from the BVC that will be displayed. This was because the gird animation only shows the BVC snapshot if it thinks there will be a difference between it and the cell snapshot -- specifically when there's been a device rotation. This CL lets the grid view controller flag the active cell in the animation as "appearing" so that the animation can always show the BVC's snapshot in that case. Bug: 865978 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iede4af004e89e5fda1395c4257c3d74fd2a682c7 Reviewed-on: https://chromium-review.googlesource.com/1156685 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579470}(cherry picked from commit 69e4263a35e7b987052183cfbbce719287129483) Reviewed-on: https://chromium-review.googlesource.com/1159942 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#332} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm [modify] https://crrev.com/242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255/ios/chrome/browser/ui/tab_grid/transitions/grid_to_visible_tab_animator.mm [modify] https://crrev.com/242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm [modify] https://crrev.com/242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_layout.h [modify] https://crrev.com/242c38ebdd5c3ee10abb1d25f0e5f37ddd89e255/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_layout.mm
,
Aug 7
Verified in: App Version: 70.0.3515.0 canary Devices: iPhone 7 Plus, iPhone 8 Plus, iPad Air iOS Version:10.3.3, 11.4.1, 12.0 beta 6 Not showing white blank screen when opening new tab from tab grid.
,
Aug 8
Verified in build 69.0.3497.31 Beta on iPhoneX iOS 11.4, iPhone 7+ iOS 10.3.3, iPad Pro 12.9' iOS 11.4 Not showing white blank screen when opening new tab from tab grid. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by marq@chromium.org
, Jul 20