New issue
Advanced search Search tips

Issue 865977 link

Starred by 1 user
Status: Fixed
Owner:
osh...@chromium.org
Closed: Jul 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

double click to toggle maximize on detached / wide caption of arc++ app does not work.

Project Member Reported by osh...@chromium.org, Jul 20 
double click to toggle maximize on detached / wide caption of arc++ app does not work.

repro step
1) install snapchat
2) maximize
3) double click on caption
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098f2aee1e634dae3c699b51fb5327b6787cdc6e

commit 098f2aee1e634dae3c699b51fb5327b6787cdc6e
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Jul 20 19:16:24 2018

Toggle maximize when double clicked on wide frame

BUG= 865977 
TEST=Covered by unit test


Change-Id: I444981ec98241d2a355d23d9711a961010a292c3
Reviewed-on: https://chromium-review.googlesource.com/1144628
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576947}
[modify] https://crrev.com/098f2aee1e634dae3c699b51fb5327b6787cdc6e/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/098f2aee1e634dae3c699b51fb5327b6787cdc6e/ash/frame/wide_frame_view.cc
[modify] https://crrev.com/098f2aee1e634dae3c699b51fb5327b6787cdc6e/ash/frame/wide_frame_view.h

Comment 2 by osh...@chromium.org, Jul 20

Labels: Merge-Request-69
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 21

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c694de9b7ffd59f69a276437593e6e2f760d812

commit 5c694de9b7ffd59f69a276437593e6e2f760d812
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Sun Jul 22 16:20:30 2018

Toggle maximize when double clicked on wide frame

BUG= 865977 
TEST=Covered by unit test


Change-Id: I444981ec98241d2a355d23d9711a961010a292c3
Reviewed-on: https://chromium-review.googlesource.com/1144628
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576947}(cherry picked from commit 098f2aee1e634dae3c699b51fb5327b6787cdc6e)
Reviewed-on: https://chromium-review.googlesource.com/1146086
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#9}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/5c694de9b7ffd59f69a276437593e6e2f760d812/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/5c694de9b7ffd59f69a276437593e6e2f760d812/ash/frame/wide_frame_view.cc
[modify] https://crrev.com/5c694de9b7ffd59f69a276437593e6e2f760d812/ash/frame/wide_frame_view.h

Comment 5 by osh...@chromium.org, Jul 22

Status: Fixed (was: Started)
►

Sign in to add a comment