I think that we need to fix this for the launch. WDYT?

Necessary for landing? Definitely. 

Not sure about the P1 for launch, though:
Dismissing the keyboard hides the accessory as well and the button can be pressed again. The implementation of restricting the content area (i.e. what makes scrolling possible again) isn't trivial.

This should be fixed when the accessory pushes up content: https://crrev.com/c/1177361

 Issue 875077  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7f385986a69d648d77b0b9f7821e7901df5c90f

commit f7f385986a69d648d77b0b9f7821e7901df5c90f
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Aug 17 08:00:41 2018

[Android] Make keyboard accessory views independent from BottomContainer

With this CL, the view stubs (and the views) are moved out of the
bottom container, which makes it possible (and necessary) to push up
all visible content.

This fixes:
 - the accessory overlaying page contents (esp. bad for fullscreen)
 - the accessory being pushed up by the keyboard (visual flickering)
 - clicking through the accessory

This changes:
 - the bar isn't pushed up by bottom sheets (like download) anymore BUT
   instead pushes them up when the bottom sheet is opened

Bug: 874257,  873591 , 704070,  853745 ,  865964 
Change-Id: I8185b1ac21aaaed3d7123855b8964a3f86c9845a
Reviewed-on: https://chromium-review.googlesource.com/1177361
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583987}
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/res/layout/keyboard_accessory.xml
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/res/layout/keyboard_accessory_sheet.xml
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/res/layout/main.xml
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetMediator.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModel.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/f7f385986a69d648d77b0b9f7821e7901df5c90f/chrome/browser/password_manager/password_accessory_controller_unittest.cc

Fixed for 70.0.3528.4 and newer (see Canary screenshot).

Deleted: reviewing-fixed-canary-70.0.3528.4.png 150 KB

	reviewing-fixed-canary-70.0.3528.4.png 150 KB View Download