New issue
Advanced search Search tips

Issue 865943 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Change string to view and manage passwords in Chrome Settings to match desktop

Project Member Reported by ioanap@chromium.org, Jul 20

Issue description

When navigating to Chrome > Settings > Passwords on Android, a string
about where the user can view and manage their saved passwords is displayed. 
This string needs to be changed to ensure consistency with desktop.
 
Description: Show this description
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a1d26c2ea20b7eb334a3e23b46eaac22d3e7432

commit 8a1d26c2ea20b7eb334a3e23b46eaac22d3e7432
Author: Ioana Pandele <ioanap@chromium.org>
Date: Fri Jul 20 13:04:08 2018

Change string to view and manage passwords on Android

This change is made to ensure consistency with Desktop.

Bug:  865943 , 862269
Change-Id: I3fb2a72017f122dcf94308bf5a14bb39a1ead90f
Reviewed-on: https://chromium-review.googlesource.com/1144921
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576839}
[modify] https://crrev.com/8a1d26c2ea20b7eb334a3e23b46eaac22d3e7432/chrome/android/java/strings/android_chrome_strings.grd

Status: Fixed (was: Assigned)
Labels: Merge-Request-69
This is only a string change. The string has already been changed on desktop for M69 and this would ensure consistency between platforms.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 23

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 42 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: benmason@chromium.org
Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 24

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68ad177797618c447e0e2981b6cadace6a12f93

commit c68ad177797618c447e0e2981b6cadace6a12f93
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Jul 24 09:23:43 2018

Change string to view and manage passwords on Android

This change is made to ensure consistency with Desktop.

Bug:  865943 , 862269
Change-Id: I3fb2a72017f122dcf94308bf5a14bb39a1ead90f
Reviewed-on: https://chromium-review.googlesource.com/1144921
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576839}(cherry picked from commit 8a1d26c2ea20b7eb334a3e23b46eaac22d3e7432)
Reviewed-on: https://chromium-review.googlesource.com/1148180
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#34}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/c68ad177797618c447e0e2981b6cadace6a12f93/chrome/android/java/strings/android_chrome_strings.grd

Sign in to add a comment