Issue metadata
Sign in to add a comment
|
Voice over scroll actions are improper in tab switcher mode |
||||||||||||||||||||||||
Issue descriptionApp Version: 69.0.3497.0 canary iOS Version: iOS 11.4,12 Device: iPhones only Precondition : 1- Enable voice over from device settings. Steps to reproduce: 1. Launch Chrome 2. Go to incognito mode. 3. Tap on Tab Switcher and close incognito tab. 4. Scroll the cursor from Incognito to Normal and Other devices. 5. Try to Scroll the cursor to the center text. Observed results: Cursor moves to new tab or Recent tabs Expected results: Cursor should be in incognito mode. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA New UI in M69 Bug reproducible on the current beta channel build : Yes in M69 Link to video/image: https://drive.google.com/file/d/1LVfQjdpjfxs4-F9ou0Qm73Htn3hpogxm/view?usp=sharing
,
Jul 24
P1 since this breaks the tab grid for VoiceOver users. Load-balancing to kkhorimoto@
,
Jul 26
,
Jul 26
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f117ff452c82a39c0ab351dc2d724246f3f98f4 commit 2f117ff452c82a39c0ab351dc2d724246f3f98f4 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Jul 31 21:09:06 2018 [iOS] Hide a11y elements of offscreen pages in the tab grid. This prevents voice over from scrolling to these screens when they aren't visible. Bug: 865938 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b27176c59a496fc0bb38468cfe11670c79529bd Reviewed-on: https://chromium-review.googlesource.com/1152366 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579570} [modify] https://crrev.com/2f117ff452c82a39c0ab351dc2d724246f3f98f4/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jul 31
Setting next action date for canary verification.
,
Aug 1
,
Aug 1
The NextAction date has arrived: 2018-08-01
,
Aug 1
Verified in canary today; screen does not scroll to other pages in voiceover. Requesting merge for M69
,
Aug 1
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0592a2981a7f61799db8087b12465ea0bbe5b4ae commit 0592a2981a7f61799db8087b12465ea0bbe5b4ae Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Wed Aug 01 15:51:51 2018 [iOS] Hide a11y elements of offscreen pages in the tab grid. This prevents voice over from scrolling to these screens when they aren't visible. Bug: 865938 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b27176c59a496fc0bb38468cfe11670c79529bd Reviewed-on: https://chromium-review.googlesource.com/1152366 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579570}(cherry picked from commit 2f117ff452c82a39c0ab351dc2d724246f3f98f4) Reviewed-on: https://chromium-review.googlesource.com/1158766 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#312} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/0592a2981a7f61799db8087b12465ea0bbe5b4ae/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Aug 7
Verified in 69.0.3497.25 Beta, iPhone X iOS 11.4 Looks good.
,
Aug 8
Issue verified Version: Chrome Beta 69.0.3497.31 Device: iPhone 8 iOS: 11.4 Cursor stays in incognito mode. https://drive.google.com/open?id=1FZxxLrqxXIVx7_IK4-YvOlE92ZInFQIB |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by olivierrobin@chromium.org
, Jul 20Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)