New issue
Advanced search Search tips

Issue 865933 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add metrics for Ephemeral Flash Permissions

Project Member Reported by rhalavati@chromium.org, Jul 20

Issue description

Metrics are needed to check the effect of ephemeral Flash permissions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b6456d432a1e61bd96d531301e6d41f7b4f7ebb

commit 3b6456d432a1e61bd96d531301e6d41f7b4f7ebb
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Aug 01 11:29:39 2018

Add metrics for Flash ephemeral permissions.

A metric is added to count the number of times Flash permissions are
set for a website. The counter is separated based on whether this is the
first granting of permission or the next times.

Bug:  865933 
Change-Id: If33aaf4915109f6e7ed49dc1e7142c64b6981fac
Reviewed-on: https://chromium-review.googlesource.com/1145197
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579759}
[modify] https://crrev.com/3b6456d432a1e61bd96d531301e6d41f7b4f7ebb/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/3b6456d432a1e61bd96d531301e6d41f7b4f7ebb/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3b6456d432a1e61bd96d531301e6d41f7b4f7ebb/tools/metrics/histograms/histograms.xml

Labels: -Pri-3 Merge-Request-69 Pri-2
Requesting a merge. This is late after branchpoint, but it's only a metric, so the scope of the code change is small.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 3

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OSs label.
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
How critical is this for M69? 
It is not critical, but without this metric we cannot gauge how much this change is affecting the users.
It accompanies an M69 launch. While we have existing metrics that will give us some insight into it, only this new metric properly measures its impact.

We won't break anything if we don't merge it. But the risk is also small, as it's just reading a value and recording it in UMA. We did manually test it in Canary too.
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #7 and #8. Pls merge now. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 7

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8600e55333a3bf27ad2387ac95285ae34deb2563

commit 8600e55333a3bf27ad2387ac95285ae34deb2563
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Aug 07 11:02:33 2018

Add metrics for Flash ephemeral permissions.

A metric is added to count the number of times Flash permissions are
set for a website. The counter is separated based on whether this is the
first granting of permission or the next times.

Bug:  865933 
Change-Id: If33aaf4915109f6e7ed49dc1e7142c64b6981fac
Reviewed-on: https://chromium-review.googlesource.com/1145197
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579759}(cherry picked from commit 3b6456d432a1e61bd96d531301e6d41f7b4f7ebb)
TBR: holte@chromium.org
TBR: markusheintz@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1164982
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#461}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/8600e55333a3bf27ad2387ac95285ae34deb2563/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/8600e55333a3bf27ad2387ac95285ae34deb2563/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8600e55333a3bf27ad2387ac95285ae34deb2563/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment