Add metrics for Ephemeral Flash Permissions |
|||||||
Issue descriptionMetrics are needed to check the effect of ephemeral Flash permissions.
,
Aug 3
Requesting a merge. This is late after branchpoint, but it's only a metric, so the scope of the code change is small.
,
Aug 3
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 4
Pls apply appropriate OSs label.
,
Aug 6
,
Aug 6
How critical is this for M69?
,
Aug 6
It is not critical, but without this metric we cannot gauge how much this change is affecting the users.
,
Aug 6
It accompanies an M69 launch. While we have existing metrics that will give us some insight into it, only this new metric properly measures its impact. We won't break anything if we don't merge it. But the risk is also small, as it's just reading a value and recording it in UMA. We did manually test it in Canary too.
,
Aug 6
Approving merge to M69 branch 3497 based on comment #7 and #8. Pls merge now. Thank you.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8600e55333a3bf27ad2387ac95285ae34deb2563 commit 8600e55333a3bf27ad2387ac95285ae34deb2563 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Aug 07 11:02:33 2018 Add metrics for Flash ephemeral permissions. A metric is added to count the number of times Flash permissions are set for a website. The counter is separated based on whether this is the first granting of permission or the next times. Bug: 865933 Change-Id: If33aaf4915109f6e7ed49dc1e7142c64b6981fac Reviewed-on: https://chromium-review.googlesource.com/1145197 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579759}(cherry picked from commit 3b6456d432a1e61bd96d531301e6d41f7b4f7ebb) TBR: holte@chromium.org TBR: markusheintz@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1164982 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#461} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8600e55333a3bf27ad2387ac95285ae34deb2563/components/content_settings/core/browser/host_content_settings_map.cc [modify] https://crrev.com/8600e55333a3bf27ad2387ac95285ae34deb2563/tools/metrics/histograms/enums.xml [modify] https://crrev.com/8600e55333a3bf27ad2387ac95285ae34deb2563/tools/metrics/histograms/histograms.xml
,
Aug 8
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 1