New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865920 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor out ResponseCapturer and place it in a shared location.

Project Member Reported by armax@google.com, Jul 20

Issue description

When writing tests that involve the usage of an async dbus api, it is non-trivial to extract and inspect the response from the related callback since the object used for the response is passed as a unique_ptr and hence ownership cannot be retained.
A solution was implemented and copied over in other tests here: https://chromium.googlesource.com/chromiumos/platform2/+/HEAD/login_manager/session_manager_impl_unittest.cc#236

Since this is a fairly useful mechanism for testing, it needs to be refactored out and placed in a shared location.
 
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Status: WontFix (was: Assigned)
Eventually, we designed the tests to avoid leaking the implementation details related to dbus. As a result we were able to get rid of the ResponseCapture class in favor of a simple callback.

Sign in to add a comment