Issue metadata
Sign in to add a comment
|
[Mac-Views] Regression: Blue color is not seen for links in omnibox suggestion |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3497.0 OS: Windows 10, Debian, Mac 10.13.6 What steps will reproduce the problem? (1) Launch chrome ,type chrome:// and observe for suggestions with blue color Expected: Links in suggestion list should be blue in color Actual: Instead links are back in color. This is a regression issue broken in M-69. Good Build: 69.0.3496.0 Bad Build: 69.0.3497.0 You are probably looking for a change made after 576552 (known good), but no later than 576553 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/c54f59fb4dbc7291c01bb015bf1db2b9a383983d..e1e91e62b942b8a2a27ad62dfaee0a6e0cf28b67 @ellyjones: Please check the screencast and let us know if this is an issue or intended behavior. Please help in re-assigning if this is not related to your change. Thanks!
,
Jul 21
,
Jul 21
Issue 866221 has been merged into this issue.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5 commit c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Jul 24 14:04:24 2018 views: recompute omnibox text colors Resetting the text to the default color is incorrect - OmniboxTextView::SetText contains logic to apply special colors depending on the type of result. This change adds a method to OmniboxTextView called ReapplyStyling() which causes OmniboxTextView to recompute and reapply this text styling. This is necessary in high contrast modes because these use different text styling for the selected or hovered result. Bug: 865918 Change-Id: Ia2c68e6cb3329b1d58d86dc9f6999420810a9d6d Reviewed-on: https://chromium-review.googlesource.com/1145136 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577519} [modify] https://crrev.com/c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5/chrome/browser/ui/views/omnibox/omnibox_text_view.cc [modify] https://crrev.com/c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5/chrome/browser/ui/views/omnibox/omnibox_text_view.h
,
Jul 24
,
Jul 24
Pls update the bug with canary result tomorrow. Thank you.
,
Jul 25
The NextAction date has arrived: 2018-07-25
,
Jul 25
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/277ce8d6645539598334be981cabe6fe5ca2264b commit 277ce8d6645539598334be981cabe6fe5ca2264b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Jul 25 14:53:50 2018 views: recompute omnibox text colors Resetting the text to the default color is incorrect - OmniboxTextView::SetText contains logic to apply special colors depending on the type of result. This change adds a method to OmniboxTextView called ReapplyStyling() which causes OmniboxTextView to recompute and reapply this text styling. This is necessary in high contrast modes because these use different text styling for the selected or hovered result. TBR=ellyjones@chromium.org (cherry picked from commit c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5) Bug: 865918 Change-Id: Ia2c68e6cb3329b1d58d86dc9f6999420810a9d6d Reviewed-on: https://chromium-review.googlesource.com/1145136 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577519} Reviewed-on: https://chromium-review.googlesource.com/1150089 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3493@{#11} Cr-Branched-From: 00d1887a807c3b7ab3c802a0fd9aef0f658b7a85-refs/heads/master@{#575194} [modify] https://crrev.com/277ce8d6645539598334be981cabe6fe5ca2264b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/277ce8d6645539598334be981cabe6fe5ca2264b/chrome/browser/ui/views/omnibox/omnibox_text_view.cc [modify] https://crrev.com/277ce8d6645539598334be981cabe6fe5ca2264b/chrome/browser/ui/views/omnibox/omnibox_text_view.h
,
Jul 25
Fix merged to 3493.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bc9a57cebfb7289eaefc35a327864c6b34879ce commit 6bc9a57cebfb7289eaefc35a327864c6b34879ce Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Jul 25 14:57:22 2018 views: recompute omnibox text colors Resetting the text to the default color is incorrect - OmniboxTextView::SetText contains logic to apply special colors depending on the type of result. This change adds a method to OmniboxTextView called ReapplyStyling() which causes OmniboxTextView to recompute and reapply this text styling. This is necessary in high contrast modes because these use different text styling for the selected or hovered result. TBR=ellyjones@chromium.org (cherry picked from commit c50c83b11e7a0dd65b97ce2b8c94e97ee813fbf5) Bug: 865918 Change-Id: Ia2c68e6cb3329b1d58d86dc9f6999420810a9d6d Reviewed-on: https://chromium-review.googlesource.com/1145136 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577519} Reviewed-on: https://chromium-review.googlesource.com/1150090 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#68} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/6bc9a57cebfb7289eaefc35a327864c6b34879ce/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/6bc9a57cebfb7289eaefc35a327864c6b34879ce/chrome/browser/ui/views/omnibox/omnibox_text_view.cc [modify] https://crrev.com/6bc9a57cebfb7289eaefc35a327864c6b34879ce/chrome/browser/ui/views/omnibox/omnibox_text_view.h
,
Aug 1
Able to reproduce the issue on build without fix, hence verifying the issue on latest dev #69.0.3497.23 using Windows 10, debian and Mac 10.13.6 Now Observing text color in Omnibox as blue As fix is working as expected adding TE-Verified labels. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by chelamcherla@chromium.org
, Jul 20