Manually passing --js-flags=--no-opt to chrome or content_shell has no effect |
||
Issue descriptionThis is due to V8Initializer::Initialize in gin/v8_initializer.cc explicitly passing --opt to V8 (unless disabled through some other means?).
,
Jul 20
Perhaps the issue is merely that the --js-flags get processed before the above function is called.
,
Jul 20
I'll have a look at this, but not sure I can do it today (and out next week). As a workaround, you can use the chrome flag "--disable-features=V8OptimizeJavascript" to disable optimization in gin.
,
Jul 20
No problem, thanks!
,
Jul 20
re #2 - that's probable, however the alternative (processing --js-flags after V8 has been initialized) has other issues, e.g., the flags aren't correctly set during initialization and so might have not effect.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0d3d4bfeaee0f35de94171d15e1deef9f912a9 commit 8f0d3d4bfeaee0f35de94171d15e1deef9f912a9 Author: Ross McIlroy <rmcilroy@chromium.org> Date: Fri Jul 27 01:51:47 2018 [Gin] Avoid explicitly setting --opt if features::kV8OptimizeJavascript is enabled. This is the default, and doing so prevents passing --no-opt via other means. BUG= chromium:865913 Change-Id: I017d940809020d4015e245e9cb4ac3b166ad67b8 Reviewed-on: https://chromium-review.googlesource.com/1148730 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578517} [modify] https://crrev.com/8f0d3d4bfeaee0f35de94171d15e1deef9f912a9/gin/v8_initializer.cc
,
Jul 27
|
||
►
Sign in to add a comment |
||
Comment 1 by neis@chromium.org
, Jul 20