New issue
Advanced search Search tips

Issue 865907 link

Starred by 2 users
Status: Fixed
Owner:
alemate@chromium.org
Closed: Jul 21
Cc:
ajha@chromium.org
alemate@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessarily 'Back' button is seen in Bold letters in 'sign in as an existing user' screen

Project Member Reported by mmanchala@chromium.org, Jul 20 
Chrome Version:  69.0.3494.0/10893.0.0 dev channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> At Uber Tray select 'Sign out' ->  in sign out screen Click on 'Add person'
(2)Now at Uber Tray turn-off WI-FI -> "Network not available" page is seen
(3)Now click on 'sign in as an existing user' -> Observe 'Back' button is seen in Bold letters
(Please refer Video)

Note: In "Network not available" page 'Back' button is not seen in Bold letters
(Please refer 'Expected_BackButtonInNetworknotAvailable' screenshot)

Expected: 'Back' button should not be seen in Bold letters
Actual: Instead 'Back' button is seen in Bold letters

This is Regression Issue as same is working fine in M-68
Actual_BoldBackButton.mp4
12.0 MB View Download
Actual_BoldBackButton.jpg
529 KB View Download
Expected_BackButtonInNetworknotAvailable.jpg
669 KB View Download
Expected_Text.jpg
773 KB View Download

Comment 1 by jdufault@chromium.org, Jul 20

Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by alemate@chromium.org, Jul 21

Labels: Merge-Request-69
Status: Fixed (was: Assigned)
Button is actually necessary (as it goes back to sign-in screen).

Style is fixed.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 22

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 23

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/366da3126ec8ddd0a66f64b53d4f165e4d021061

commit 366da3126ec8ddd0a66f64b53d4f165e4d021061
Author: Alexander Alekseev <alemate@chromium.org>
Date: Mon Jul 23 20:16:21 2018

ChromeOS OOBE: default <slot> values were not styled.

This Cl fixes issue with <oobe-back-button> and <oobe-next-button> when
text styling was not applied to <slot> default values.

TBR=alemate@chromium.org

(cherry picked from commit e9e512762d33e0c4e9f6adcc258f6c551fe79bc3)

Bug:  865907 
Change-Id: I035e0c9144527a84c6865f6fae3d86d34272c169
Reviewed-on: https://chromium-review.googlesource.com/1145870
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577054}
Reviewed-on: https://chromium-review.googlesource.com/1147332
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#25}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/366da3126ec8ddd0a66f64b53d4f165e4d021061/chrome/browser/resources/chromeos/login/hd-iron-icon.html
[modify] https://crrev.com/366da3126ec8ddd0a66f64b53d4f165e4d021061/chrome/browser/resources/chromeos/login/oobe_back_button.css
[modify] https://crrev.com/366da3126ec8ddd0a66f64b53d4f165e4d021061/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/366da3126ec8ddd0a66f64b53d4f165e4d021061/chrome/browser/resources/chromeos/login/oobe_next_button.css
[modify] https://crrev.com/366da3126ec8ddd0a66f64b53d4f165e4d021061/chrome/browser/resources/chromeos/login/oobe_text_buttons.css
►

Sign in to add a comment