New issue
Advanced search Search tips

Issue 865899 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Other passwords do not get encrypted after deleting entry from chrome://settings/passwords.

Reported by pranjali...@etouch.net, Jul 20

Issue description

Chrome version : 69.0.3497.0 (Official Build)  a7025597556ee57a06aaffb0472693e2b3ee395d-refs/branch-heads/3497@{#1}(32/64-bit) 

OS: Windows (7,8,8.1,10) ,Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS

Pre-condition: Atleast 2-3 passwords entries should be present under chrome://settings/passwords

What steps will reproduce the problem?
1.Launch chrome and navigate to 'chrome://settings/passwords'.
2. Click on eye icon of all entries so that all passwords are visible.
3.Now remove second/third password entry and observe.

Actual  :  Other passwords do not get encrypted  after deleting 2/3 password entry from chrome://settings/passwords.
Expected: All password entries should be seen encrypted after deleting 2/3 password entry from chrome://settings/passwords.

This is a regression issue broken in ‘M-68’ and below is bisect info.
Good build: 68.0.3425.0
Bad build: 68.0.3427.0

https://chromium.googlesource.com/chromium/src/+log/56205ade5fedcee73206c6f7ebc9d1cb33763cd6..894c79630192ac3b94dccebb5dfab3a473385aa5	

Suspecting : https://chromium.googlesource.com/chromium/src/+/79911889545c81db13572295c2dff37120c7da1d

@aee: Could you please check whether this is caused with respect to your change, if not please help to reassigning it to the right owner.

Thank You!
 
Actual Result.mp4
452 KB View Download
Expected Result.mp4
446 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a312e36b2338dec25e4e5a53039ec914e005ceb6

commit a312e36b2338dec25e4e5a53039ec914e005ceb6
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Jul 24 18:49:44 2018

Settings: passwords and forms, clear password from view on update

Bug:  865899 
Change-Id: Ic759da99d5dd11f2e08b201b731bab8006da7b38
Reviewed-on: https://chromium-review.googlesource.com/1145625
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577625}
[modify] https://crrev.com/a312e36b2338dec25e4e5a53039ec914e005ceb6/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.js
[modify] https://crrev.com/a312e36b2338dec25e4e5a53039ec914e005ceb6/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Status: Fixed (was: Started)
Labels: TE-Verified-M70 TE-Verified-70.0.3503.0
Update:

Rechecked the above issue on Windows (7,8,8.1,10) ,Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS using latest canary build #70.0.3503.0 and issue is still reproducible.Issue is seen for 2-3 password entries in chrome://settings/passwords.

Please refer attached screencast for same.

Thank You...
Labels: -TE-Verified-M70 -TE-Verified-70.0.3503.0
Labels: TE-Verified-M70 TE-Verified-70.0.3524.0
Update:
Rechecked the above issue on Windows (7,8,8.1,10) ,Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS using latest canary build #70.0.3524.0 and issue is fixed.

Please refer attached screencast for reference.

Thank You..
Canary_behaviour.mp4
1.6 MB View Download
Labels: -TE-Verified-M70 -TE-Verified-70.0.3524.0
Note
Please ignore above comment (i.e comment#6) 

Sign in to add a comment