'+' sign on 'New tab' button is not centre aligned in incognito window.
Reported by
avsha...@etouch.net,
Jul 20
|
|||||||||
Issue descriptionChrome Version : 69.0.3497.0 (Official Build) a7025597556ee57a06aaffb0472693e2b3ee395d-refs/branch-heads/3497@{#1} 32/64 bit OS : Windows (7, 8, 8.1, 10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and open incognito window. 2. Observe the 'New tab' button in tab strip. Actual Result : '+' sign on 'New tab' button is not centre aligned in incognito window. Expected Result : '+' sign on 'New tab' button should be centre aligned in incognito mode. This is a Non-regression issue seen from M-69 series, since the 'Black background' color for 'New tab' button is newly added in build #69.0.3497.0 Note: 1. Above issue is not observed in Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS. Thank you..!
,
Jul 20
Yep, need to change the path computation in refresh away from what touchable refresh was doing.
,
Jul 20
Gah!
,
Jul 20
,
Jul 20
I am unable to reproduce this using 3497. Is there something I'm missing?
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c7beac8599e334ad1ad0413fefadf7a292e65e9 commit 7c7beac8599e334ad1ad0413fefadf7a292e65e9 Author: Allen Bauer <kylixrd@chromium.org> Date: Fri Jul 20 22:06:57 2018 Use the ShouldDrawIncognitoIcon() oracle in GetNewerMaterialUiButtonPath(). Bug: 865898 Change-Id: I4c25a2900927b979f697f426eb92da2d68ecff7b Reviewed-on: https://chromium-review.googlesource.com/1145722 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577007} [modify] https://crrev.com/7c7beac8599e334ad1ad0413fefadf7a292e65e9/chrome/browser/ui/views/tabs/new_tab_button.cc
,
Jul 23
Update : Tested above issue in latest Canary build #70.0.3500.0 on Windows(7, 8, 8.1, 10) & Linux(14.04 LTS) OS and the issue is fixed. '+' sign on 'New tab' button is now properly aligned with the background color. Kindly review an attached screen-cast for reference. Thank you..!
,
Jul 23
,
Sep 14
This wasn't merged to M69 and was re-reported in 880857. It's a small change and would be nice since we're re-spinning M69.
,
Sep 14
Approving merge to M69 branch 3497 based on comment #9 and per offline chat with pkasting@. Pls merge. Thank you.
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aae17a8e3f2ee297a02c0903c0e026a7d081f22 commit 2aae17a8e3f2ee297a02c0903c0e026a7d081f22 Author: Allen Bauer <kylixrd@chromium.org> Date: Fri Sep 14 23:14:40 2018 Use the ShouldDrawIncognitoIcon() oracle in GetNewerMaterialUiButtonPath(). Bug: 865898 Change-Id: I4c25a2900927b979f697f426eb92da2d68ecff7b Reviewed-on: https://chromium-review.googlesource.com/1145722 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577007}(cherry picked from commit 7c7beac8599e334ad1ad0413fefadf7a292e65e9) Reviewed-on: https://chromium-review.googlesource.com/1227481 Cr-Commit-Position: refs/branch-heads/3497@{#944} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2aae17a8e3f2ee297a02c0903c0e026a7d081f22/chrome/browser/ui/views/tabs/new_tab_button.cc
,
Sep 17
Update : --------- Tested above issue in Stable build #69.0.3497.100 on Windows (7, 8, 8.1, 10) & Linux(14.04 LTS) OS and the issue is fixed. Now, background color and '+' sign icon is centre aligned with each other in incognito mode, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nyerramilli@chromium.org
, Jul 20