New issue
Advanced search Search tips

Issue 865890 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Recent Tabs - VisualEffects on Sticky header

Project Member Reported by martijnb@chromium.org, Jul 20

Issue description

Enable the VisualEffects on the sticky section headers in Recent Tabs.
Also applies to Recents in Tab Grid. 

This will be consistent with the other Collections. 
 
Labels: Q2
Status: Assigned (was: Untriaged)
Cc: rohitrao@chromium.org
Owner: sczs@chromium.org
I'll take this one
Issue 868118 has been merged into this issue.
Labels: -Q2 -Pri-2 M-70 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a327b41c392422661bc15453f898fbe7874b90

commit c8a327b41c392422661bc15453f898fbe7874b90
Author: sczs <sczs@chromium.org>
Date: Mon Aug 13 20:21:39 2018

[ios] Adds visual effect to Disclosure HeaderFooterView

The background added for optimization to DisclosureHeaderFooterView
was removing the VisualEffect being set in the parent class. This CL
moves the optimization background to the parent class in case there's
no visual effect being set.

Bug:  865890 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7b50ed65fc47c93b6548ca2eb60bd139071c8f28
Reviewed-on: https://chromium-review.googlesource.com/1171856
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582688}
[modify] https://crrev.com/c8a327b41c392422661bc15453f898fbe7874b90/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm
[modify] https://crrev.com/c8a327b41c392422661bc15453f898fbe7874b90/ios/chrome/browser/ui/table_view/cells/table_view_header_footer_item.mm

Status: Fixed (was: Started)

Sign in to add a comment