New issue
Advanced search Search tips

Issue 865889 link

Starred by 2 users
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jul 20
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

scroll properties should not accept unitless length quirk

Project Member Reported by ericwilligers@chromium.org, Jul 20 
Only specific legacy properties should accept unitless lengths in quirks mode, not the various new scroll properties

See
https://quirks.spec.whatwg.org/#the-unitless-length-quirk
https://github.com/w3c/csswg-drafts/issues/2928

WPT requested in
https://github.com/web-platform-tests/wpt/issues/12047

Affected properties:
scroll-margin-block-end
scroll-margin-block-start
scroll-margin-bottom
scroll-margin-inline-end
scroll-margin-inline-start
scroll-margin-left
scroll-margin-right
scroll-margin-top
scroll-padding-block-end
scroll-padding-block-start
scroll-padding-bottom
scroll-padding-inline-end
scroll-padding-inline-start
scroll-padding-left
scroll-padding-right
scroll-padding-top
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68b785b9db4853ca2762d1f356256849bd405c44

commit 68b785b9db4853ca2762d1f356256849bd405c44
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Fri Jul 20 15:54:43 2018

CSS: scroll properties do not accept unitless lengths

The following properties no longer accept unitless lengths in quirks mode:
scroll-margin-block-end
scroll-margin-block-start
scroll-margin-bottom
scroll-margin-inline-end
scroll-margin-inline-start
scroll-margin-left
scroll-margin-right
scroll-margin-top
scroll-padding-block-end
scroll-padding-block-start
scroll-padding-bottom
scroll-padding-inline-end
scroll-padding-inline-start
scroll-padding-left
scroll-padding-right
scroll-padding-top

The only properties that should accept unitless lengths in quirks mode
are listed in
https://quirks.spec.whatwg.org/#the-unitless-length-quirk


BUG= 865889 

Change-Id: Id700932eda312dc0292b2c4a25ddbb57f2f99aa9
Reviewed-on: https://chromium-review.googlesource.com/1144991
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576880}
[add] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/WebKit/LayoutTests/external/wpt/quirks/unitless-length/excluded-properties.html
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_block_end_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_block_start_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_bottom_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_inline_end_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_inline_start_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_left_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_right_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_margin_top_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_block_end_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_block_start_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_bottom_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_inline_end_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_inline_start_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_left_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_right_custom.cc
[modify] https://crrev.com/68b785b9db4853ca2762d1f356256849bd405c44/third_party/blink/renderer/core/css/properties/longhands/scroll_padding_top_custom.cc

Comment 2 by ericwilligers@chromium.org, Jul 20

Status: Fixed (was: Started)
►

Sign in to add a comment