New issue
Advanced search Search tips

Issue 865888 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Bookmarks - Change "Select" String to "Edit"

Project Member Reported by martijnb@chromium.org, Jul 20

Issue description

When entering a Bookmarks folder in Bookmarks, the bottom toolbar icon says "Select".
This should be "Edit", just like the other collections. 


 
Labels: Q2
Status: Assigned (was: Untriaged)
Labels: -Q2 -Pri-3 M-70 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/012c9b03138d1b8398b756565826b93d95cf8277

commit 012c9b03138d1b8398b756565826b93d95cf8277
Author: sczs <sczs@chromium.org>
Date: Thu Aug 16 19:41:42 2018

[ios] Changes Bookmarks Button text from Select to Edit

Bug:  865888 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8b2a42cb29983fa309b4dd337d526b7a2d4fe05
Reviewed-on: https://chromium-review.googlesource.com/1176871
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583774}
[modify] https://crrev.com/012c9b03138d1b8398b756565826b93d95cf8277/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/012c9b03138d1b8398b756565826b93d95cf8277/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
https://drive.google.com/file/d/1AsE67trIPSj5mYwMqTA3TNZtoa-jZEgC/view?usp=sharing

Verified on iPhone X iOS 12 Beta 9, iPhone 6+ 11.4, iPad Pro12'9 iOS 11.4.1

Sign in to add a comment