New issue
Advanced search Search tips

Issue 865880 link

Starred by 2 users
Status: Assigned
Owner:
reillyg@chromium.org
Cc:
kcwu@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

master-paladin failure on ImageTest

Project Member Reported by oka@chromium.org, Jul 20 
stout-paladin https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=stout-paladin&buildBranch=master
leon-paladin https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=leon-paladin&buildBranch=master
gale-paladin https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=gale-paladin&buildBranch=master
daisy-paladin https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8940504065601743616


https://luci-logdog.appspot.com/v/?s=chromeos/bb/chromeos/daisy-paladin/30052/+/recipes/steps/ImageTest/0/stdout

======================================================================
FAIL: TestGroups (chromite.cros.test.image_test.UserGroupTest)
Enforces a whitelist of known group IDs.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/host/source/chromite/cros/test/image_test.py", line 596, in TestGroups
    self._CheckFile('group')
  File "/mnt/host/source/chromite/cros/test/image_test.py", line 588, in _CheckFile
    self.assertTrue(success)
AssertionError: False is not true

Comment 3 by kcwu@chromium.org, Jul 20 

The error mentioned in issue description is related to
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1137104

There are messages about devbroker-access in log file

...00:50:07: ERROR: New group "devbroker-access" has users "set(['chronos'])"
00:50:07: ERROR: Unexpected group entry for "devbroker-access".

Comment 4 by oka@chromium.org, Jul 20

Labels: -Pri-0 Pri-2
-1ed the culprit. https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1137104

Comment 5 by oka@chromium.org, Jul 20

Owner: reillyg@chromium.org

Comment 6 by reillyg@chromium.org, Jul 20

Owner: oka@chromium.org
oka@, I believe that https://chromium-review.googlesource.com/c/chromiumos/overlays/eclass-overlay/+/1136497 is the culprit, as in that change I tried to remove chronos from the devbroker-access group before landing https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1137104 to remove the check. I have since reversed the dependency between these two CLs. Can you remove your -1 so I can land these in the correct order.

Comment 7 by vapier@chromium.org, Jul 20 

land them with a CQ-DEPEND on each other so they're atomic

Comment 8 by oka@chromium.org, Jul 20 

Removed -1. Thank you.

Comment 9 by oka@chromium.org, Jul 20

Owner: reillyg@chromium.org

Comment 10 by reillyg@chromium.org, Jul 21 

vapier@, thanks for the tip. I'm attempting to land these issues atomically as you suggest. Should I close this issue? This isn't a failure in a merged patch so I don't understand what the issue lifecycle should be.

Comment 11 by oka@chromium.org, Jul 22 

There's no strict lifecycle AFAIK.
I think you can mark this as fixed once the blamed CLs are committed.

Comment 12 by oka@chromium.org, Jul 22 

I mean landed.
►

Sign in to add a comment