New issue
Advanced search Search tips

Issue 865866 link

Starred by 0 users
Status: Fixed
Owner:
chenghan@chromium.org
Closed: Jul 21
Cc:
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Factory makefile ignores private overlay resources when resource/ does not exist.

Project Member Reported by chenghan@chromium.org, Jul 20 
Chrome Version: ToT
OS: ChromeOS

Factory makefile does not find private overlay resources when the directory `chromeos-base/factory-board/files/resources` in private overlay doesn't exist. Some overlays do not have this directory, but still have some essential files that need to be included, such as `py/config/cutoff.json`.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ef43e8657b11f7d9cac28b11e25676b8b62dd90c

commit ef43e8657b11f7d9cac28b11e25676b8b62dd90c
Author: Cheng-Han Yang <chenghan@google.com>
Date: Fri Jul 20 15:36:37 2018

Makefile: Get private overlay resource when resource/ does not exist.

The factory makefile ignores private overlay resources when the directory
`chromeos-base/factory-board/files/resources/` does not exist. The CL
changes the makefile to always find resource files even if the directory
does not exist.

BUG= chromium:865866 
TEST=Find an overlay with py/config/cutoff.json and without resource/;
     `emerge-<board> chromeos-base/factory`;
     `emerge-<board> chromeos-base/factory_installer`;
     `script/build_image --board=<board> factory_install`;
     Mount factory shim, see cutoff.json in /usr/share/cutoff/

Change-Id: I081183a5dfebb3a5031d801b21c85a45dc385cf7
Reviewed-on: https://chromium-review.googlesource.com/1144815
Commit-Ready: Cheng-Han Yang <chenghan@chromium.org>
Tested-by: Cheng-Han Yang <chenghan@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/ef43e8657b11f7d9cac28b11e25676b8b62dd90c/devtools/mk/create_resources.py
[modify] https://crrev.com/ef43e8657b11f7d9cac28b11e25676b8b62dd90c/Makefile

Comment 2 by chenghan@chromium.org, Jul 21

Status: Fixed (was: Untriaged)
►

Sign in to add a comment