Tweak "Open in New Tab" animation |
|||||
Issue description- exit fullscreen when the action is triggered and before the animation runs - adjust the tab switcher bump animation to make it a bit more prominent (no specs; will just play with it in Xcode) - tint the link icon a dark grey (start with black @ 0.4 and we can tweak from there)
,
Aug 1
,
Aug 20
I am upgrading this to a P1 for M70. Please speak up if you disagree.
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4928caea785ce11b50238d478f676f9138a632a commit c4928caea785ce11b50238d478f676f9138a632a Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Aug 21 13:08:25 2018 [iOS] Tweak OpenInNewTab animation This CL updates the OpenInNewTab animation. Bug: 865863 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1138a23bb96c9b81e50f247b5bf2b293df001e60 Reviewed-on: https://chromium-review.googlesource.com/1181128 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584721} [modify] https://crrev.com/c4928caea785ce11b50238d478f676f9138a632a/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/c4928caea785ce11b50238d478f676f9138a632a/ios/chrome/browser/ui/tabs/background_tab_animation_view.mm [modify] https://crrev.com/c4928caea785ce11b50238d478f676f9138a632a/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
,
Aug 21
,
Aug 29
Verified in 70.0.3535.0 canary in iPhone 7plus(iOS 10.3.3), iPhone 8plus(iOS 12 beta 11), iPhone 8plus(iOS 11.4.1) and iPad 2018(iOS 11.4.1) Open in new tab animation is modified as per comment#0, Looks good link to video: https://drive.google.com/file/d/1NyEy0PE3Sx6JwcYOs2P7daBaCrhg0AzH/view?usp=sharing |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gambard@chromium.org
, Jul 20