tast: Disable graphics.Screenshot test on devices without display |
|||
Issue descriptionForked from https://bugs.chromium.org/p/chromium/issues/detail?id=865117#c8 Some devices do not have displays (e.g. panther and monroe) so graphics.Screenshot test always fails. We should disable the test on those devices.
,
Jul 31
To be more precise, skip only screenshot, not all graphics tests. Most graphics tests work fine on devices without display.
,
Aug 1
ihf@: sure, updated the title.
,
Aug 1
Talked with derat@ offline. I'll start with USE=display_backlight to detect the internal display. Maybe we need to revisit after we convert more boards to unibuilds.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ad1fd20040eb4291e658145ffda4d15d6686de53 commit ad1fd20040eb4291e658145ffda4d15d6686de53 Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Aug 02 20:52:52 2018 tast-use-flags: Include display_backlight. BUG= chromium:865853 TEST=emerge-caroline --nodeps tast-use-flags Change-Id: I3b4f68ce2c2e108ed01611cbf63ebb59f1203f52 Reviewed-on: https://chromium-review.googlesource.com/1158098 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/ad1fd20040eb4291e658145ffda4d15d6686de53/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r5.ebuild [modify] https://crrev.com/ad1fd20040eb4291e658145ffda4d15d6686de53/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/ec3ba195d418c2422124a28938690ab4e0d64de8 commit ec3ba195d418c2422124a28938690ab4e0d64de8 Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Aug 02 20:52:54 2018 graphics.Screenshot: Require an internal display. BUG= chromium:865853 TEST=tast run caroline-DUT graphics.Screenshot CQ-DEPEND=CL:1158099 Change-Id: I0ddfe946773372f75fe116048f98fc14ac1472ac Reviewed-on: https://chromium-review.googlesource.com/1158100 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/ec3ba195d418c2422124a28938690ab4e0d64de8/src/chromiumos/tast/local/bundles/cros/graphics/screenshot.go
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/dd13172490d81a5849146d9b7f76e0d9df97ac4c commit dd13172490d81a5849146d9b7f76e0d9df97ac4c Author: Shuhei Takahashi <nya@chromium.org> Date: Thu Aug 02 20:52:53 2018 tast: Define display_backlight software deps. BUG= chromium:865853 TEST=tast run caroline-DUT graphics.Screenshot CQ-DEPEND=CL:1158098 Change-Id: Iafa695f4f0a08259c812451c4e61f97947b56f7d Reviewed-on: https://chromium-review.googlesource.com/1158099 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/dd13172490d81a5849146d9b7f76e0d9df97ac4c/src/chromiumos/cmd/local_test_runner/main.go [modify] https://crrev.com/dd13172490d81a5849146d9b7f76e0d9df97ac4c/docs/test_dependencies.md
,
Aug 3
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nya@chromium.org
, Jul 31