Navigating to a Signed Exchange should preserve URL fragment |
||||
Issue descriptionWhile loading a Signed Exchange UA's supposed to make an internal redirect to the inner URL, which should preserve URL fragments (if it follows regular redirect) but current implementation doesn't. We probably should copy and attach the fragment in SignedExchangeLoader::OnHTTPExchangeFound.
,
Jul 23
,
Jul 23
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e43057b3c7b0b3a977421c9c4bc08740ef5ae51f commit e43057b3c7b0b3a977421c9c4bc08740ef5ae51f Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Mon Jul 23 07:12:46 2018 Signed Exchange: Preserve URL fragment This patch makes SignedExchangeLoader propagate URL fragment from outer request URL to redirect (inner) URL. Bug: 865852 Change-Id: Ib4000508464a4d0cf82c4757aca05c0d670ed647 Reviewed-on: https://chromium-review.googlesource.com/1146410 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577116} [modify] https://crrev.com/e43057b3c7b0b3a977421c9c4bc08740ef5ae51f/content/browser/web_package/signed_exchange_loader.cc [modify] https://crrev.com/e43057b3c7b0b3a977421c9c4bc08740ef5ae51f/content/browser/web_package/signed_exchange_loader.h [add] https://crrev.com/e43057b3c7b0b3a977421c9c4bc08740ef5ae51f/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location-fragment.html [add] https://crrev.com/e43057b3c7b0b3a977421c9c4bc08740ef5ae51f/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/sxg-location-fragment-expected.txt
,
Jul 23
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f246f59d15841439ed4bffa98447994fb1d1764d commit f246f59d15841439ed4bffa98447994fb1d1764d Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Mon Aug 27 03:43:57 2018 Signed Exchange: Add a test for fallback redirect with URL fragment Bug: 865852 Change-Id: I3dea747eca69722f2abfbfdebd5d7e05eeabf743 Reviewed-on: https://chromium-review.googlesource.com/1189508 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586188} [add] https://crrev.com/f246f59d15841439ed4bffa98447994fb1d1764d/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-fallback-with-fragment.html [add] https://crrev.com/f246f59d15841439ed4bffa98447994fb1d1764d/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/sxg-fallback-with-fragment-expected.txt |
||||
►
Sign in to add a comment |
||||
Comment 1 by kinuko@chromium.org
, Jul 20