The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28da169692913062e2291c3d7815d7ef4437990

commit b28da169692913062e2291c3d7815d7ef4437990
Author: Tim Song <tengs@chromium.org>
Date: Fri Jul 20 05:57:27 2018

Fix BLE advertisement on macOS.

The CoreBluetooth APIs expect CBUUID objects instead of raw UUID strings.

BUG= 865851 
TBR=ortuno

Change-Id: I1ad7ac21a9213d0ee19edafe54f7de096b283347
Reviewed-on: https://chromium-review.googlesource.com/1144657
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576793}
[modify] https://crrev.com/b28da169692913062e2291c3d7815d7ef4437990/device/bluetooth/bluetooth_low_energy_advertisement_manager_mac.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5b9a2b1c7638f50d80aa491e778a870bc9e28e

commit 1d5b9a2b1c7638f50d80aa491e778a870bc9e28e
Author: Robert Liao <robliao@chromium.org>
Date: Fri Jul 20 18:14:30 2018

Revert "Fix BLE advertisement on macOS."

This reverts commit b28da169692913062e2291c3d7815d7ef4437990.

Reason for revert: This is a dependent revert for 
https://chromium-review.googlesource.com/c/chromium/src/+/1142294

Root Reason:

Causes build break
device/bluetooth/bluetooth_low_energy_advertisement_manager_mac.mm:26:35: error: comparison of two values with different enumeration types ('CBManagerState' and 'CBPeripheralManagerState') [-Werror,-Wenum-compare]
  if ([peripheral_manager_ state] < CBPeripheralManagerStatePoweredOn) {
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Original change's description:
> Fix BLE advertisement on macOS.
> 
> The CoreBluetooth APIs expect CBUUID objects instead of raw UUID strings.
> 
> BUG= 865851 
> TBR=ortuno
> 
> Change-Id: I1ad7ac21a9213d0ee19edafe54f7de096b283347
> Reviewed-on: https://chromium-review.googlesource.com/1144657
> Commit-Queue: Tim Song <tengs@chromium.org>
> Reviewed-by: Tim Song <tengs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576793}

TBR=tengs@chromium.org,sacomoto@chromium.org,ortuno@chromium.org

Change-Id: I99fd190bc75a8f572d2129cb3843e8fb747c503d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  865851 
Reviewed-on: https://chromium-review.googlesource.com/1145562
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576924}
[modify] https://crrev.com/1d5b9a2b1c7638f50d80aa491e778a870bc9e28e/device/bluetooth/bluetooth_low_energy_advertisement_manager_mac.mm

@tengs: I don't think your commit in comment#1 caused the `comparison of two values with different enumeration types` error. I get the same compile error at #576753 which is before your commit landed. This is on macOS 10.13.4 (17E199) with Xcode 9.3 (9E145).

Never mind, I see that this was reverted because of https://bugs.chromium.org/p/chromium/issues/detail?id=846881#c4

Is this fixed? This is not a P0.

@robliao @tengs:

It looks like the broken commit was included in 3497 branch (M69):

https://chromium-review.googlesource.com/q/I48b76e84d67060e7265533759752fcc0e84f5cc6

But the commit fixing the breakage does not appear to be merged in 3497 branch:

https://storage.googleapis.com/chromium-find-releases-static/b28.html#b28da169692913062e2291c3d7815d7ef4437990

For some reason I've lost view permissions on issue #846881. Can someone either confirm that this issue has been fixed in M69 or request that the fix be merged?

Thanks.

I also merged the fix into M69:
https://chromium-review.googlesource.com/c/chromium/src/+/1162209