Migrate all update_payload dependencies |
|
Issue descriptionThere are currently a few dependencies to update_payload. But it is quite easy to remove those dependencies mainly because update_payload does not exist in chromite anymore. 1. There are two source code for cros_payload.py. We need to move the unittest for it to the update_payload and deprecate use the one in update_engine in cros payload show. in addition cros payload show is dependent on update_payload scripts which do not exist in the chromite anymore so this weird dependency can be removed. 2. There is one dependency in autoupdate.py which is totally useless and should be removed. 3 There is one in auto_updater.py too which should be removed.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b96253cab7d9acd6c40a22e1f8f192e61fbc027a commit b96253cab7d9acd6c40a22e1f8f192e61fbc027a Author: Amin Hassani <ahassani@chromium.org> Date: Tue Jul 24 04:04:55 2018 cros_payload: deprecate it The cros_payload scripts have been moved to update_engine/scripts/payload_info.py. This is a utility used for looking into structure of an update payload. Hence, it is better to be next to other update payload utilities. No body currently is actively using cros_payload except the update_engine maintainers locally. BUG=chromium:865845 TEST=precq Change-Id: If9fd243b3e60e8360d9f91ca02de1ab2e2ee10b8 Reviewed-on: https://chromium-review.googlesource.com/1145479 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [delete] https://crrev.com/5389d34c833dae162248c0c8ddb1b71d31851924/cli/cros/cros_payload_unittest [delete] https://crrev.com/5389d34c833dae162248c0c8ddb1b71d31851924/cli/cros/cros_payload_unittest.py [delete] https://crrev.com/5389d34c833dae162248c0c8ddb1b71d31851924/cli/cros/cros_payload.py
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/50dd2f03b827509c6f78cc4379d7f6c893517f6b commit 50dd2f03b827509c6f78cc4379d7f6c893517f6b Author: Amin Hassani <ahassani@chromium.org> Date: Tue Jul 24 04:04:44 2018 update_payload: import cros_payload_unittest.py as is import from chromite/cli/cros/cros_payload_unittest.py BUG=chromium:865845 TEST=none Change-Id: I4b1d0a65e1e0d19cd230e90651075afad26eded2 Reviewed-on: https://chromium-review.googlesource.com/1144642 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Xiaochu Liu <xiaochu@chromium.org> [add] https://crrev.com/50dd2f03b827509c6f78cc4379d7f6c893517f6b/scripts/payload_info_unittest.py
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/fdc488d61200fd3445033c61b01c3d6ddfa46bb2 commit fdc488d61200fd3445033c61b01c3d6ddfa46bb2 Author: Amin Hassani <ahassani@chromium.org> Date: Tue Jul 24 04:04:44 2018 update_payload: Modify payload_info_unittest.py This patch modifies payload_info_unittest.py to run in the unittests and actives it in the run_unittests script. This removes the dependency to the chromite utils used for unit testing and creates small similar tools to capture those behaviors. BUG=chromium:865845 TEST=unitests Change-Id: Ib931831ce9c4b0ae3fc2f62972db82ec2ec5897f Reviewed-on: https://chromium-review.googlesource.com/1144643 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Xiaochu Liu <xiaochu@chromium.org> [modify] https://crrev.com/fdc488d61200fd3445033c61b01c3d6ddfa46bb2/scripts/run_unittests [modify] https://crrev.com/fdc488d61200fd3445033c61b01c3d6ddfa46bb2/scripts/payload_info_unittest.py |
|
►
Sign in to add a comment |
|
Comment 1 by ahass...@chromium.org
, Jul 20