NTP on CrOS and desktop: unable to access toast to undo removing a tile keyboard only |
|||||||||||||||
Issue descriptionGoogle Chrome 69.0.3473.0 (Official Build) dev (64-bit) Firmware Version Google_Lulu.6301.136.57 Steps to repro: # Navigate to the NTP (new tab page) # Use tab to navigate to the small x next to one of the tiles and press enter to remove it # Toast appears for undo or restore all Expected: way to get to buttons using keyboard only Actual: not in tab order Please see screenshot for this toast.
,
Aug 8
,
Aug 9
Google Chrome 70.0.3514.0 (Official Build) dev (64-bit) (cohort: Dev) Windows 10 Also reproduces on desktop in 70 with a slightly different interface design (see screenshot).
,
Aug 10
This is fixed in 70.0.3518.0 with #ntp-custom-links enabled.
,
Aug 10
,
Aug 10
,
Aug 23
Google Chrome 70.0.3524.2 (Official Build) dev (64-bit) Firmware Version Google_Lulu.6301.136.57 Reopening since the issue repros even with #ntp-custom-links enabled. Both with and without the flag enabled, the toast will appear below the tile but it will not be announced and user has no way of knowing that it appeared.
,
Aug 24
,
Aug 27
,
Aug 27
,
Aug 27
Regarding the toast not being announced: The notification has role="alert", which should announce it to screen readers if visibility is changed. In this case, we remove the class that sets "display:none" when the notification is shown, which should trigger the alert event. However, this doesn't seem to be the case, and I suspect that the style attribute must be set on the element directly.
,
Aug 27
I think the explicit focus on 'Undo' (crrev.com/c/1188492) will resolve this. Currently (70.0.3530.0) on CrOS, removing a custom link announces, "Alert Shortcut removed Undo Restore default shortcuts Google" because focus moves to the Google logo. After the focus change, it should change to ""Alert Shortcut removed Undo Restore default shortcuts Undo".
,
Sep 5
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f107e6c78054dca34047d4a029f92b9d3bff7177 commit f107e6c78054dca34047d4a029f92b9d3bff7177 Author: Weilun Shi <sweilun@chromium.org> Date: Wed Sep 05 02:18:04 2018 [NTP] Focus on undo button when notification bar float up When the custom link tile gets modified(add/edit/delete), focusing on the undo button on the notification bar. Using tab on undo button can navigate to restore button as well. Bug: 873978 , 865840 Change-Id: Idf8420d3622e645e8980fc40be5682028daf8638 Reviewed-on: https://chromium-review.googlesource.com/1188492 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#588741} [modify] https://crrev.com/f107e6c78054dca34047d4a029f92b9d3bff7177/chrome/browser/resources/local_ntp/custom_links_edit.js [modify] https://crrev.com/f107e6c78054dca34047d4a029f92b9d3bff7177/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/f107e6c78054dca34047d4a029f92b9d3bff7177/chrome/browser/resources/local_ntp/most_visited_single.js
,
Sep 6
Able to reproduce the issue on Windows 10 on the reported version 69.0.3473.0 and but unable to verify the fix on the latest M-71(71.0.3544.0) build as the same bad behavior is observed. Steps: ======= 1. Launched Chrome and opened NTP. 2. Navigated to the small x next to one of the tiles, by pressing the tab key and press enter to remove it. 3. Cannot observe the focus on undo button Attached is the screen cast for reference. Note: Tried the issue by enabling/disabling the flag #ntp-custom-links and unable to observe the good behavior. sweilun@ Request you to check and confirm if anything is missed from our end in verifying the issue and help us in verifying the fix on the latest M-71 build. Thanks..
,
Sep 6
It's weird that this UI should be obsoleted by now. We don't use the square most visited tile anymore. Kindly refer to the screencast on the latest Windows chromium.
,
Oct 9
Issue 893519 has been merged into this issue.
,
Oct 9
Reassigning to add to remote NTP
,
Nov 9
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by fgor...@chromium.org
, Jul 31