Credit card autocomplete is offered when it shouldn't be |
|||||
Issue descriptionChrome Version : 68.0.3440.68 OS Version: OS X 10.13.5 URLs (if applicable) : https://jsbin.com/vehenoliga/1/edit?html,output What steps will reproduce the problem? 1. Go to https://jsbin.com/vehenoliga/1/edit?html,output, click within the "Número de documento" field What happens? Chrome shows autocomplete info for my credit cards What should happen? Chrome should not show credit card autocomplete info, the input element includes `autocomplete="new-doc"`. According to https://bugs.chromium.org/p/chromium/issues/detail?id=468153, if Chrome encounters an autocomplete field it doesn't know, it shouldn't provide autocomplete info. If you change the label for the field and remove "Número", Chrome no longer shows credit card autocomplete info. From the original report: Garbarino (https://www.garbarino.com) is using Autofill for the checkout form, and started to see that Chrome is suggesting credit card values for a field that belongs to the user's national ID. They are using `autocomplete="new-doc"`, which is not a standard value, in an attempt to prevent any automatic field to be shown. Steps to reproduce: 1. Go to a product: https://www.garbarino.com/producto/celular-libre-motorola-moto-c-negro/21cc6f3382 2. Click on "Comprar". 3. Click on "Continuar". 4. Complete information, until step 3. 5. Start typing any values on the field: "Número de documento". UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.68 Safari/537.36
,
Jul 20
,
Jul 20
parastoog@ Could you please take a look? thanks!
,
Jul 25
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe8d29cebf89cb8ed5c11ade2a7ba4ff5f0e7e3 commit 6fe8d29cebf89cb8ed5c11ade2a7ba4ff5f0e7e3 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Wed Jul 25 19:54:38 2018 [Autofill] Regex for credit card number heuristics For a label to represent a credit card number having the word number is not enough. We need to make sure the label doesn't contain the words that denote other fields such as document or phone. Test added. Bug: 865838 Change-Id: I06f606b8a324336509dcccbcce98262d43cd00f0 Reviewed-on: https://chromium-review.googlesource.com/1148960 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578025} [modify] https://crrev.com/6fe8d29cebf89cb8ed5c11ade2a7ba4ff5f0e7e3/components/autofill/core/common/autofill_regex_constants.cc [add] https://crrev.com/6fe8d29cebf89cb8ed5c11ade2a7ba4ff5f0e7e3/components/test/data/autofill/heuristics/input/152_garbarino_document_number_not_cc.html [add] https://crrev.com/6fe8d29cebf89cb8ed5c11ade2a7ba4ff5f0e7e3/components/test/data/autofill/heuristics/output/152_garbarino_document_number_not_cc.out
,
Jul 25
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rsesek@chromium.org
, Jul 20