Other devices text shows up as black |
|||||||
Issue descriptionIn Canary, navigate to tab switcher, then recent tabs. Have no other devices connected. Then see the text below "Other Devices" is black text on black background (like in screenshot).
,
Jul 20
I can repro this no problem. Thanks Gabe, Khalil!
,
Jul 20
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3 commit 7c48c7410756f48ecde2a1d7cd3eb6673e255ba3 Author: sczs <sczs@chromium.org> Date: Fri Jul 20 21:59:43 2018 [ios] Fixes TableViewTextItem text color assignment. TextItemColorBlack was being used as the default color even if textColor was not being set. This was causing the item label to skip the styler textColor for the label. This CL fixes that problem and introduces some unit_tests to check this. Bug: 865808 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic9e7d368d4acb5cab8f2585762c69363c1143749 Reviewed-on: https://chromium-review.googlesource.com/1145584 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577003} [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm [modify] https://crrev.com/7c48c7410756f48ecde2a1d7cd3eb6673e255ba3/ios/chrome/browser/ui/table_view/cells/table_view_text_item_unittest.mm
,
Jul 23
I've verified this issue on Canary, so we should be ready to cherrypick.
,
Jul 24
Approved!
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddf4374e95c7978e42eb7997859167af82898a04 commit ddf4374e95c7978e42eb7997859167af82898a04 Author: sczs <sczs@chromium.org> Date: Thu Jul 26 15:43:58 2018 [ios] Fixes TableViewTextItem text color assignment. TextItemColorBlack was being used as the default color even if textColor was not being set. This was causing the item label to skip the styler textColor for the label. This CL fixes that problem and introduces some unit_tests to check this. TBR=sczs@chromium.org (cherry picked from commit 7c48c7410756f48ecde2a1d7cd3eb6673e255ba3) Bug: 865808 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic9e7d368d4acb5cab8f2585762c69363c1143749 Reviewed-on: https://chromium-review.googlesource.com/1145584 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577003} Reviewed-on: https://chromium-review.googlesource.com/1151529 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#111} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/table_view/cells/table_view_text_item.h [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm [modify] https://crrev.com/ddf4374e95c7978e42eb7997859167af82898a04/ios/chrome/browser/ui/table_view/cells/table_view_text_item_unittest.mm
,
Jul 31
Verified on chrome canary version 70.0.3508.0 on iPhone 8 plus and iPad pro with iOS 11.4.1. No text is displayed in the back ground in other devices tab.
,
Aug 1
Verified in 69.0.3497.22 beta in iPhone 8plus(iOS 12 beta 5), iPad pro(iOS 11.4.1) Text below "Other Devices" is displayed in white text, looks good |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ghendel@chromium.org
, Jul 20