Cronet HttpTest.SystemCookieWithNullCreationTime triggers DCHECKs on iOS 12 beta3 |
||
Issue descriptionThe iOS-specific function GetCreationTimeFromObject() in cookie_creation_time_manager.mm fails the following DCHECK: // The "Created" key is not documented. // Return a null time if the key is missing. id created = [[cookie properties] objectForKey:kHTTPCookieCreated]; DCHECK(created && [created isKindOfClass:[NSNumber class]]); It appears that 'Created' key is missing. Removing the DCHECK makes tests pass. Interestingly, cookie_creation_time_manager_unittest doesn't trigger this DCHECK.
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/600742eb2a0a265ac9d441c02e92203c64e17d80 commit 600742eb2a0a265ac9d441c02e92203c64e17d80 Author: Misha Efimov <mef@chromium.org> Date: Wed Aug 01 11:36:48 2018 [Cronet] Disable DCHECK(created) in GetCreationTimeFromObject. - iOS 12 returns nil for system cookie with null creation time. Bug: 865803 , 688540 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I612b4ab55aedb0a2c0d9b2a7cb24418c5a0a6c19 Reviewed-on: https://chromium-review.googlesource.com/1157229 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#579763} [modify] https://crrev.com/600742eb2a0a265ac9d441c02e92203c64e17d80/ios/net/cookies/cookie_creation_time_manager.mm
,
Aug 1
|
||
►
Sign in to add a comment |
||
Comment 1 by olivierrobin@chromium.org
, Jul 20Owner: mef@chromium.org
Status: Assigned (was: Untriaged)