Issue 865800 link

Starred by 0 users

Issue metadata

Status:	Fixed
Owner:	achuith@chromium.org
Closed:	Aug 3
Cc:	dgarr...@chromium.org vapier@chromium.org alemate@chromium.org glevin@chromium.org nedngu...@google.com achuith@chromium.org mukai@chromium.org
Components:	Tests>Telemetry
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug

amd64-generic-telemetry perf test failure due to missing httplib2

Project Member Reported by achuith@chromium.org, Jul 20

Issue description

Failure log:
07/15 06:49:17.051 INFO |run_chromeos_tests:0022| Running unit tests in /usr/local/telemetry/src/tools/perf with browser_type "system".
07/15 06:52:28.086 INFO |run_chromeos_tests:0052| Failed to import test module: process_perf_results_unittest
07/15 06:52:28.087 INFO |run_chromeos_tests:0052| Traceback (most recent call last):
07/15 06:52:28.087 INFO |run_chromeos_tests:0052|   File "/usr/local/lib64/python2.7/unittest/loader.py", line 254, in _find_tests
07/15 06:52:28.088 INFO |run_chromeos_tests:0052|     module = self._get_module_from_name(name)
07/15 06:52:28.088 INFO |run_chromeos_tests:0052|   File "/usr/local/lib64/python2.7/unittest/loader.py", line 232, in _get_module_from_name
07/15 06:52:28.089 INFO |run_chromeos_tests:0052|     __import__(name)
07/15 06:52:28.089 INFO |run_chromeos_tests:0052|   File "/usr/local/telemetry/src/tools/perf/process_perf_results_unittest.py", line 21, in <module>
07/15 06:52:28.089 INFO |run_chromeos_tests:0052|     import process_perf_results as ppr_module
07/15 06:52:28.090 INFO |run_chromeos_tests:0052|   File "/usr/local/telemetry/src/tools/perf/process_perf_results.py", line 19, in <module>
07/15 06:52:28.090 INFO |run_chromeos_tests:0052|     from core import upload_results_to_perf_dashboard
07/15 06:52:28.091 INFO |run_chromeos_tests:0052|   File "/usr/local/telemetry/src/tools/perf/core/upload_results_to_perf_dashboard.py", line 17, in <module>
07/15 06:52:28.091 INFO |run_chromeos_tests:0052|     from core import results_dashboard
07/15 06:52:28.092 INFO |run_chromeos_tests:0052|   File "/usr/local/telemetry/src/tools/perf/core/results_dashboard.py", line 14, in <module>
07/15 06:52:28.092 INFO |run_chromeos_tests:0052|     import httplib2
07/15 06:52:28.093 INFO |run_chromeos_tests:0052| ImportError: No module named httplib2
07/15 06:52:28.093 INFO |run_chromeos_tests:0052| 
07/15 06:52:28.149 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 631, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 495, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 362, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 400, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/telemetry_UnitTests/telemetry_UnitTests.py", line 35, in run_once
    raise error.TestFail(error_str)
TestFail: The unit tests of /usr/local/telemetry/src/tools/perf failed.


First failing build:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8940952891164761696

Revision log:
https://chromium.googlesource.com/chromium/src/+log/69.0.3488.0..69.0.3491.0?pretty=fuller&n=10000

CL that is most probably responsible:
https://chromium-review.googlesource.com/c/chromium/src/+/1127845

Comment 1 by achuith@chromium.org, Jul 24

Cc: vapier@chromium.org glevin@chromium.org dgarr...@chromium.org
Status: Started (was: Assigned)
Summary: amd64-generic-telemetry perf test failure due to missing httplib2 (was: amd64-generic-telemetry perf test failure)

To fix the import httplib2 failure, I tried this CL:
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1147748

It doesn't work. Mike/Dan: Any idea why?
To test the CL:
cros_workon start chromeos-base/autotest-chrome
cros_workon start chromeos-base/autotest-tests
build_packages
etc

Comment 2 by vapier@chromium.org, Jul 24

prob need to add the dep to virtual/target-chromium-os-test instead

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/80c4502fe1ff643ad0a2e6b586f584a072db2fea

commit 80c4502fe1ff643ad0a2e6b586f584a072db2fea
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Jul 26 11:07:53 2018

chromium-os-test: Add httplib2

Fix import error in telemety_UnitTests_perf

BUG= chromium:865800 
TEST=telemetry_UnitTests_perf

Change-Id: If7cbb8c8f74f9265381dd794603e4f35fd5c96b6
Reviewed-on: https://chromium-review.googlesource.com/1147748
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/80c4502fe1ff643ad0a2e6b586f584a072db2fea/virtual/target-chromium-os-test/target-chromium-os-test-1-r71.ebuild
[modify] https://crrev.com/80c4502fe1ff643ad0a2e6b586f584a072db2fea/virtual/target-chromium-os-test/target-chromium-os-test-1.ebuild

Comment 4 by achuith@chromium.org, Jul 27

Also missing logdog_helper:
process_perf_results_unittest.ProcessPerfResultsIntegrationTest.testIntegration failed unexpectedly 0.0097s:
07/27 09:56:33.270 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
07/27 09:56:33.271 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/process_perf_results_unittest.py", line 63, in setUp
07/27 09:56:33.271 INFO |run_chromeos_tests:0052|       m2.start()
07/27 09:56:33.272 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/mock/mock.py", line 1396, in start
07/27 09:56:33.273 INFO |run_chromeos_tests:0052|       result = self.__enter__()
07/27 09:56:33.274 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/mock/mock.py", line 1252, in __enter__
07/27 09:56:33.274 INFO |run_chromeos_tests:0052|       self.target = self.getter()
07/27 09:56:33.275 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/mock/mock.py", line 1414, in <lambda>
07/27 09:56:33.276 INFO |run_chromeos_tests:0052|       getter = lambda: _importer(target)
07/27 09:56:33.277 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/mock/mock.py", line 1102, in _importer
07/27 09:56:33.277 INFO |run_chromeos_tests:0052|       thing = _dot_lookup(thing, comp, import_path)
07/27 09:56:33.278 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/third_party/mock/mock.py", line 1091, in _dot_lookup
07/27 09:56:33.279 INFO |run_chromeos_tests:0052|       __import__(import_path)
07/27 09:56:33.280 INFO |run_chromeos_tests:0052|   ImportError: No module named logdog_helper

Comment 5 by nednguyen@chromium.org, Jul 27

That test can be safely disabled for ChromeOS. It basically tests the recipe integration, which I don't think is useful for ChromeOS infra at the moment.

Comment 6 by achuith@chromium.org, Jul 27

Cc: achuith@chromium.org
Owner: glevin@chromium.org

Sounds good!

Greg: Can you disable this test on ChromeOS?
https://yaqs.googleplex.com/eng/q/5925879191961600

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8908c642a68dc176917811229f74b73780554422

commit 8908c642a68dc176917811229f74b73780554422
Author: glevin <glevin@chromium.org>
Date: Sat Jul 28 00:45:56 2018

Disable ProcessPerfResultsIntegrationTest.testIntegration on chromeos

Bug:  865800 
TEST: Disabled!!

Change-Id: Ib4f9622e031ace72111cfbe6e1f5fead36905e8b
Reviewed-on: https://chromium-review.googlesource.com/1153660
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578878}
[modify] https://crrev.com/8908c642a68dc176917811229f74b73780554422/tools/perf/process_perf_results_unittest.py

Comment 8 by glevin@chromium.org, Jul 29

Done.  Can we mark this Fixed, or was there some additional work that someone wanted to do here?

Comment 9 by achuith@chromium.org, Jul 29

The bot is red, looks like for an unrelated reason. Let's leave this open until we can confirm it's fixed.

Comment 10 by achuith@chromium.org, Aug 1

Cc: alemate@chromium.org
Owner: achuith@chromium.org

So the problem appears to be that Greg's fix hasn't yet made it into ChromeOS, which is currently at 70.0.3505.0:
https://chromium.googlesource.com/chromium/src/+log/70.0.3505.0?pretty=fuller&n=10000

Greg's change should hopefully be picked up soon and the bot should right itself.

Comment 11 by achuith@chromium.org, Aug 3

Status: Fixed (was: Started)

I'm not seeing this particular ImportError stack any more.

►

Issue 865800 link

Issue metadata

amd64-generic-telemetry perf test failure due to missing httplib2

Issue description

Comment 1 by achuith@chromium.org, Jul 24

Comment 1 Deleted

Comment 2 by vapier@chromium.org, Jul 24

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jul 26

Comment 3 Deleted

Comment 4 by achuith@chromium.org, Jul 27

Comment 4 Deleted

Comment 5 by nednguyen@chromium.org, Jul 27

Comment 5 Deleted

Comment 6 by achuith@chromium.org, Jul 27

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jul 28

Comment 7 Deleted

Comment 8 by glevin@chromium.org, Jul 29

Comment 8 Deleted

Comment 9 by achuith@chromium.org, Jul 29

Comment 9 Deleted

Comment 10 by achuith@chromium.org, Aug 1

Comment 10 Deleted

Comment 11 by achuith@chromium.org, Aug 3

Comment 11 Deleted

Sign in to add a comment