New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865797 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 835029



Sign in to add a comment

Limit fast app reinstall to unmanaged accounts

Project Member Reported by zalcorn@chromium.org, Jul 19

Issue description

We should only show fast app reinstall to unmanaged accounts for M70 for the sake of simplification and because this is a consumer-focused feature. We can consider making this an option available to admins of managed accounts in the future.

Yael, Sweet, Weifang, let me know if any concerns with this.
 
Ping on this - are we only showing for unmanaged?
Cc: zalcorn@chromium.org
I probably need some clarification on "unmanaged" accounts. Does that mean an account is not under education or enterprise enrollment?

Also, do we need to consider managed / unmanaged devices?
Yep "unmanaged" accounts are just consumer (@gmail.com) accounts, managed is any Dasher account (edu/enterprise, arbirary domain name).

Since policies generally apply at an account level, I don't think we need to worry about whether the device is enrolled or not, only if the account is.

Thanks for the info.

Do you know if ARC is enabled by default for the managed accounts? The current flow is that the FAR screen will only be shown after the user accepts the ARC ToS. So if ARC is enabled by default, we don't show the ARC ToS screen, and therefore, not the FAR screen as well.
It's a per-user policy - administrators can enable it or not for their domains or for specific subsets of users.
Does that mean the users won't see the ARC ToS screen?
Enterprise users will see the Play ToS screen if the ArcEnabled policy is set to "true".
Ok. Thanks for the clarification!
Sorry folks, I believe Comment #5 and #7 are incorrect as of now (after GDPR). 

When admin has turned set ARC++ to be on for the domain, a good number of situaions, users will no longer see ARC++ ToS screen in OOBE. Even more, users should not see the Fast app re-install since it's often the managed (admin OKed apps) store instead of consumer store. 

So instead, we should depend on ARC++ client receiving from Enterprise server whether it's a managed account or not in deciding whether to show the fast reinstall. 
Thanks Sweet, should have just asked you in the first place :)
Thanks Sweet, good to know. In this case, fast app reinstall screen is already correctly handled now:

- If the admin sets ARC++ to be on for the domain, users will not see ARC ToS and therefore, will not see fast reinstall screen as well.

- If the admin sets ARC++ to be off, neither ARC ToS screen nor fast reinstall screen will be shown.

If this sounds good to you, I'll close this issue.
Sorry rsgingerrs@, there is one very corner scenario where users can see the Play opt-in screen if the admin sets ARC++ to be on but also sets Backup & Restore and Google Location Services to be chosen by the user.

Is there concern to use "managed" account indicator instead of relying on Play Store opt-in dialogue (sorry we couldn't simplify)? 
Cc: atwilson@chromium.org
Thanks for letting me know about the corner scenario.

+atwilson

As far as I understand, we have a method to check if a device is managed (IsEnterpriseManaged()). But I'm not sure if we have an existing one to check whether an account is managed. IsManaged() in pref_service looks promising but I want to confirm if it is the one we should be using.
Sorry, it looks like IsManaged() in pref_service is to check if a particular pref is managed so it's not what I'm looking for.
Cc: bartfab@chromium.org
Is there a PRD for this? I can't really answer the question until I understand whether you need to gate this behavior on managed *accounts* or managed devices.
For this one we need to gate on managed accounts, not devices.
Gentle ping on this one :)
Apologies for the delayed reply - I've been traveling this week.

You want to call ProfilePolicyConnectorFactory::IsProfileManaged() for a given profile to tell if it's under management.
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f6bc65ecdebc466c31f45bc7228207f866a16e

commit 29f6bc65ecdebc466c31f45bc7228207f866a16e
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Tue Oct 02 20:33:52 2018

Disable FAR for managed and child accounts

Bug:  865797 , 889926
Change-Id: I61046742614c58c477036cf259348ce250bd889a
Reviewed-on: https://chromium-review.googlesource.com/c/1252843
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595966}
[modify] https://crrev.com/29f6bc65ecdebc466c31f45bc7228207f866a16e/chrome/browser/chromeos/login/wizard_controller.cc

Cc: rsgingerrs@chromium.org
Owner: zalcorn@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment