Make compositor serialization bitness agnostic |
||||
Issue descriptionThis will make it possible for renderer processes to be of a different bitness than gpu processes.
,
Jul 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91815ebd0af8ffb95b38291d5548cef5770b03d1 commit 91815ebd0af8ffb95b38291d5548cef5770b03d1 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Sat Jul 21 05:01:58 2018 Revert "cc, gpu: Make serialization code bitness agnostic." This reverts commit e3971799c07a4cd37daf7fb98578cb2137556648. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577038 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzOTcxNzk5YzA3YTRjZDM3ZGFmN2ZiOTg1NzhjYjIxMzc1NTY2NDgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10900 Sample Failed Step: cc_unittests Original change's description: > cc, gpu: Make serialization code bitness agnostic. > > With this change we use the same serialization regardless of whether > we are targeting a 32-bit or a 64-bit machine. > > Bug: 865796 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b > Reviewed-on: https://chromium-review.googlesource.com/1139106 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577038} Change-Id: I07ba570dd9d72eb02a929e50a2c3811c877543e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865796 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1146080 Cr-Commit-Position: refs/heads/master@{#577070} [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/image_transfer_cache_entry.cc [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/paint_filter.cc [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/paint_op_buffer.h [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/paint_op_reader.cc [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/paint_op_writer.cc [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/paint_typeface_transfer_cache_entry.cc [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/cc/paint/paint_typeface_transfer_cache_entry.h [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/gpu/command_buffer/client/client_font_manager.cc [modify] https://crrev.com/91815ebd0af8ffb95b38291d5548cef5770b03d1/gpu/command_buffer/service/service_font_manager.cc
,
Jul 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66bcb57a90138959ea5a42de0677ceb3cc0a40f0 commit 66bcb57a90138959ea5a42de0677ceb3cc0a40f0 Author: Peter Collingbourne <pcc@chromium.org> Date: Sat Jul 28 01:45:48 2018 Reland "cc, gpu: Make serialization code bitness agnostic." This is a reland of e3971799c07a4cd37daf7fb98578cb2137556648 Fixed test failures under msan, which were caused by accessing memory which was uninitialized because the read was invalid. All such accesses are now protected with a validity check. Original change's description: > cc, gpu: Make serialization code bitness agnostic. > > With this change we use the same serialization regardless of whether > we are targeting a 32-bit or a 64-bit machine. > > Bug: 865796 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b > Reviewed-on: https://chromium-review.googlesource.com/1139106 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577038} Bug: 865796 Change-Id: Id9dae1d2e5e2389ce96574c917314d63f5de5494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1152370 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578891} [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/image_transfer_cache_entry.cc [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/paint_filter.cc [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/paint_op_buffer.h [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/paint_op_reader.cc [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/paint_op_writer.cc [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/paint_typeface_transfer_cache_entry.cc [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/cc/paint/paint_typeface_transfer_cache_entry.h [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/gpu/command_buffer/client/client_font_manager.cc [modify] https://crrev.com/66bcb57a90138959ea5a42de0677ceb3cc0a40f0/gpu/command_buffer/service/service_font_manager.cc
,
Sep 12
The following revision refers to this bug: https://skia.googlesource.com/skia/+/77b02f69f26598bd9fada225bcb22a8da47b170f commit 77b02f69f26598bd9fada225bcb22a8da47b170f Author: Peter Collingbourne <pcc@google.com> Date: Wed Sep 12 13:13:24 2018 SkRemoteGlyphCache: Make serialization code bitness agnostic. With this change we use the same serialization regardless of whether we are targeting a 32-bit or a 64-bit machine. Bug: chromium:865796, chromium:880617, chromium:879123 Change-Id: Ia8e5757a4e8e3986041e30827eaaa154595c37ba Reviewed-on: https://skia-review.googlesource.com/141606 Auto-Submit: Peter Collingbourne <pcc@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> [modify] https://crrev.com/77b02f69f26598bd9fada225bcb22a8da47b170f/src/core/SkRemoteGlyphCache.cpp
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c37b9823d1a9ee4f9ba0b9ebc64f98404034cb9 commit 0c37b9823d1a9ee4f9ba0b9ebc64f98404034cb9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Sep 12 15:43:56 2018 Roll src/third_party/skia 44215505623b..b2acf0a93927 (6 commits) https://skia.googlesource.com/skia.git/+log/44215505623b..b2acf0a93927 git log 44215505623b..b2acf0a93927 --date=short --no-merges --format='%ad %ae %s' 2018-09-12 egdaniel@google.com Add unit test to test basic importing and drawing of AHardwareBuffers. 2018-09-12 reed@google.com change language for pathkit 2018-09-12 brianosman@google.com Revert "Revert "Add Adreno workaround for MSAA + stencil + ReadPixels"" 2018-09-12 pcc@google.com SkRemoteGlyphCache: Make serialization code bitness agnostic. 2018-09-12 robertphillips@google.com Loosen up assert in SkImage_Gpu::asTextureProxyRef 2018-09-12 brianosman@google.com Revert "Add Adreno workaround for MSAA + stencil + ReadPixels" Created with: gclient setdep -r src/third_party/skia@b2acf0a93927 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865796,chromium:880617,chromium:879123, chromium:882457 TBR=caryclark@chromium.org Change-Id: I14fb658d96b00737088c72237eafc0c4468417cf Reviewed-on: https://chromium-review.googlesource.com/1221690 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590695} [modify] https://crrev.com/0c37b9823d1a9ee4f9ba0b9ebc64f98404034cb9/DEPS
,
Sep 17
The following revision refers to this bug: https://skia.googlesource.com/skia/+/4a304ac44c1de0e45f92eb6fcc460a988400268c commit 4a304ac44c1de0e45f92eb6fcc460a988400268c Author: Khushal <khushalsagar@chromium.org> Date: Mon Sep 17 21:43:35 2018 SkRemoteGlyphCache: Make serialization code bitness agnostic. With this change we use the same serialization regardless of whether we are targeting a 32-bit or a 64-bit machine. No-Tree-Checks: true No-Try: true No-Presubmit: true TBR=herb@google.com Bug: chromium:865796, chromium:880617, chromium:879123 Change-Id: Ia8e5757a4e8e3986041e30827eaaa154595c37ba Reviewed-On: https://skia-review.googlesource.com/141606 Auto-Submit: Peter Collingbourne <pcc@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-By: Khusal Sagar <khushalsagar@chromium.org> Reviewed-on: https://skia-review.googlesource.com/155022 Commit-Queue: Khusal Sagar <khushalsagar@chromium.org> [modify] https://crrev.com/4a304ac44c1de0e45f92eb6fcc460a988400268c/src/core/SkRemoteGlyphCache.cpp
,
Sep 19
,
Sep 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jul 20