New issue
Advanced search Search tips

Issue 865790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

VideoFrameSubmitter must UpdateCurrentFrame on missed frames

Project Member Reported by liber...@chromium.org, Jul 19

Issue description

VFS needs to call VideoFrameCompositor::UpdateCurrentFrame on every OnBeginFrame, so that missed frames are noticed and worked into the cadence.  currently, they're skipped if we didn't get an ack for the previous CompositorFrame from viz.

if the ack hasn't arrived, then we've probably dropped a frame.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed31e65e617e652db341160f90fb845fdd0fe5e

commit 0ed31e65e617e652db341160f90fb845fdd0fe5e
Author: liberato@chromium.org <liberato@chromium.org>
Date: Fri Jul 20 00:22:46 2018

Call UpdateCurrentFrame on every VideoFrameSubmitter::OnBeginFrame.

Receiving two OnBeginFrame calls without CompositorFrameAck means
that we've dropped a frame.  Previously, we would nack the second
OnBeginFrame without also notifying the VideoFrameCompositor that
the second frame was missed.

Without an accurate count of dropped frames, the video frame
selection algorithm doesn't always perform well.

This CL makes sure that we notify the VideoFrameCompositor about
an OnBeginFrame event even if we haven't gotten an ack for a
previous one.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c5e7dbeccde700af6f00eaf5a995db2513889cf
Bug:  865790 
Reviewed-on: https://chromium-review.googlesource.com/1144304
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576711}
[modify] https://crrev.com/0ed31e65e617e652db341160f90fb845fdd0fe5e/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/0ed31e65e617e652db341160f90fb845fdd0fe5e/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

Status: Fixed (was: Started)

Sign in to add a comment