New issue
Advanced search Search tips

Issue 865787 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Jul 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Print preview loading animation hangs forever for invalid PDFs

Project Member Reported by thestig@chromium.org, Jul 19 
This is split off from bug 865125.

If the printing subsystem ever generates a print preview PDF that the PDF plugin cannot load, the loading animation runs forever, even after the PDF plugin indicated failure.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ef702c80aa7e42cf1b30cecc7e35f3b66eaef2

commit 03ef702c80aa7e42cf1b30cecc7e35f3b66eaef2
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Jul 21 02:30:06 2018

Print Preview: Improve handling of PDF load failures.

Send the document loaded message from the PDF JS code on failure. Read
the result code in the callback in Print Preview. In the case of
failure, handle it appropriately by transitioning from the loading state
to the failure state.

BUG= 865787 

Change-Id: I331fb76814affeebb0232fa064ac9a48c66c424e
Reviewed-on: https://chromium-review.googlesource.com/1144480
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577062}
[modify] https://crrev.com/03ef702c80aa7e42cf1b30cecc7e35f3b66eaef2/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/03ef702c80aa7e42cf1b30cecc7e35f3b66eaef2/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/03ef702c80aa7e42cf1b30cecc7e35f3b66eaef2/chrome/test/data/webui/print_preview/plugin_stub.js

Comment 2 by thestig@chromium.org, Jul 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment