Note that on Linux, the bookmarks bar DOES have the same color as the background behind omnibox, BUT it's light grey rather than black. Not sure whether it's intentional.

Sorry, I would have fixed the bookmarks bar together with  issue 850501 , but didn't notice it precisely because I was developing on Linux. I'm about to go OOO for a week, so I'll have to ask someone from ramyan@'s team to do it.

I believe what needs to be updated is:
1. https://cs.chromium.org/chromium/src/chrome/browser/resources/ntp4/new_incognito_tab_theme.css
2. https://cs.chromium.org/chromium/src/chrome/browser/themes/theme_properties.cc?type=cs&q=file:theme_properties.cc+"SkColor+kDefaultDetachedBookmarkBarBackgroundIncognito"

Hey msramek@ - we won't get to this next week (have tons of work on our plate) so would you mind tackling this when you come back from OOO?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83edc233fde33fe8f3082285e36b9040c1f6bf77

commit 83edc233fde33fe8f3082285e36b9040c1f6bf77
Author: Martin Šrámek <msramek@chromium.org>
Date: Thu Aug 16 17:06:18 2018

Update the color of the detached Incognito NTP bookmarks bar.

...to match the Incognito NTP background color.

Bug:  865786 
Change-Id: I87c1ea80b8405c5003f4085f71019af925617f09
Reviewed-on: https://chromium-review.googlesource.com/1177395
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583702}
[modify] https://crrev.com/83edc233fde33fe8f3082285e36b9040c1f6bf77/chrome/browser/themes/theme_properties.cc

 Issue 874269  has been merged into this issue.

Will ask for merge after verifying tomorrow. Sorry for taking so much time on this, but I had plenty of other late M69-related work, and had to get a hold of a non-Linux workstation (this doesn't reproduce on Linux). Fortunately it's just a color constant change.

This is fixed on Mac Canary now. Requesting a merge to M69.

The CL is in comment #7, and only changes one color constant value.

Tried testing the issue on build without fix #67.0.3396.99 and latest canary version #70.0.3525.0 using Mac OS 10.13.6, Ubuntu 17.10 and Windows 10 by following the below steps.

Steps:
=====
1.Launched chrome.
2.Opened incognito tab with bookmarks bar visibility off.
3.Below are the observations in 3 different OS.
In Mac : Unable to find any difference in behaviour between 67.0.3396.99 and 70.0.3525.0.
In Linux : The tabstrip, omnibox and bookmarks bar are in white color in both 67.0.3396.99 and 70.0.3525.0.
In Windows : The new tab strip and the omnibox are in grey color in 67.0.3396.99 and black in 70.0.3525.0.

Attached screenshots for reference.
msramek@: Could you please review the attached screenshots and help us in verifying the fix.

Thanks.!

Deleted: M-70(Windows).PNG 279 KB

	M-70(Windows).PNG 279 KB View Download

Deleted: M-67.(Windows)PNG 315 KB

M-67.(Windows)PNG 315 KB Download

Deleted: M-70(Linux).png 145 KB

	M-70(Linux).png 145 KB View Download

Deleted: M-67(Linux).png 147 KB

	M-67(Linux).png 147 KB View Download

Deleted: M-70(Mac).png 82.0 KB

	M-70(Mac).png 82.0 KB View Download

Deleted: M-67(Mac).png 80.9 KB

	M-67(Mac).png 80.9 KB View Download

Deleted: 67.0.3396.99.png 187 KB

	67.0.3396.99.png 187 KB View Download

Deleted: 70.0.3525.0.png 107 KB

	70.0.3525.0.png 107 KB View Download

The screenshots looks correct.

To clarify, what happened on Mac and Windows is the following:

           M67: NTP color = 323232, Bookmark bar color = 323232
M69 before fix: NTP color = 323639, Bookmark bar color = 323232
M69  after fix: NTP color = 323639, Bookmark bar color = 323639

So there *is* a difference between M67 and M70, but the fact that you can't immediately spot it confirms that the bug has been fixed. Because the colors match again.

This fix actually doesn't affect Linux, which uses (and has always used) a differently looking bookmark bar and Omnibox (light grey).

One thing that I don't see in the spec though is whether the separator line of a slightly lighter color should still be there between the NTP and the bookmark bar. I would assume so, but +maxwalker@ and +bettes@ may want to confirm. Note that it creates a "bevel" impression, as if the bookmark bar was below the NTP.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M69 branch 3497 based on comment #10 and #12. Please merge ASAP so we can pick it up for next beta release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac01713809a45c6b724ffd0ca375a4a016e997a

commit 1ac01713809a45c6b724ffd0ca375a4a016e997a
Author: Martin Šrámek <msramek@chromium.org>
Date: Sun Aug 19 21:32:07 2018

Update the color of the detached Incognito NTP bookmarks bar.

...to match the Incognito NTP background color.

TBR=estade@chromium.org

Bug:  865786 
Change-Id: I87c1ea80b8405c5003f4085f71019af925617f09
Reviewed-on: https://chromium-review.googlesource.com/1177395
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583702}(cherry picked from commit 83edc233fde33fe8f3082285e36b9040c1f6bf77)
Reviewed-on: https://chromium-review.googlesource.com/1179762
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#705}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/1ac01713809a45c6b724ffd0ca375a4a016e997a/chrome/browser/themes/theme_properties.cc

Tried to reproduce the issue on Windows 10 and Mac OS 10.13.3 on the build without fix 67.0.3396.99 and the latest M-69 build 69.0.3497.57.
Couldn't find the NTP color code and Bookmark bar color code in Devtools -> Elements to compare the values and verify the fix as per comment #12.

Attached are the screen shots of Mac and Windows behavior.

msramek@ Request you to check and help us in verifying the fix on the M-69 build.

Thanks..

Deleted: 865786-Mac-M69.png 113 KB

	865786-Mac-M69.png 113 KB View Download

Deleted: 865786-Windows-M69.png 83.7 KB

	865786-Windows-M69.png 83.7 KB View Download

Thanks for the screenshots, susan.boorgula@! I downloaded the M69 Beta on Mac, but the fix wasn't in that version yet. I could build the latest M69 (trunk) version, but I only have a Linux machine to do that, where this bug doesn't manifest (removing the Linux label now). So this is helpful.

Your screenshots look correctly. I have also verified using the color picker tool in Gimp that they indeed have the exact same color. Note that the DevTools>Elements approach doesn't work in this case, as the bookmark bar is not a HTML UI.

In the meantime I got a 69.0.3497.57 instance now as well, confirming once again that the fix made it in.