For various reasons parts of the WindowService still use PointerEvents. This results in some unnecessary conversion. We should switch the WindowService to using Mouse/Touch.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c366ee7b8720e511cfa71ae1d0933ff98d184ed commit 2c366ee7b8720e511cfa71ae1d0933ff98d184ed Author: Scott Violet <sky@chromium.org> Date: Sat Oct 06 00:46:29 2018 events: add ability to serialize TouchEvents This makes the event serialization code handle TouchEvents. I plan on doing a cleanup pass to make MouseEvent serialization use the PointerDetails struct traits. BUG= 865781 TEST=covered by tests Change-Id: I190ac58a3066c10bc08cd083702bc15232d4141d Reviewed-on: https://chromium-review.googlesource.com/c/1265160 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597383} [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/BUILD.gn [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/event.h [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/mojo/event.mojom [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/mojo/event.typemap [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/mojo/event_constants.mojom [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/mojo/event_struct_traits.h [modify] https://crrev.com/2c366ee7b8720e511cfa71ae1d0933ff98d184ed/ui/events/mojo/struct_traits_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29b31dd7fb3edad406e77b963d09b296d6133a12 commit 29b31dd7fb3edad406e77b963d09b296d6133a12 Author: Scott Violet <sky@chromium.org> Date: Mon Oct 08 18:25:59 2018 events: convert MouseEvents to use MouseData PointerData will be removed, so this converts mouse mojo serialization to use MouseData. Also converts to a couple of geometry types. Also, had to fix a couple of dependencies. BUG= 865781 TEST=covered by tests Change-Id: Iab8f2ddb5ba0f40bc43271e7135ca46f478a397d Reviewed-on: https://chromium-review.googlesource.com/c/1267495 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597618} [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/display/BUILD.gn [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/BUILD.gn [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/event.h [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/mojo/BUILD.gn [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/mojo/event.mojom [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/mojo/event.typemap [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/mojo/event_struct_traits.cc [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/mojo/event_struct_traits.h [modify] https://crrev.com/29b31dd7fb3edad406e77b963d09b296d6133a12/ui/events/mojo/struct_traits_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a commit 515fe3da84bc4ec93c8cc2288820bbeeaa5f396a Author: Scott Violet <sky@chromium.org> Date: Tue Oct 09 17:16:07 2018 window-service: makes OnWindowInputEvent() take Mouse/TouchEvent And no more PointerEvents. BUG= 865781 TEST=covered by tests Change-Id: I7279ff5f6f2068fcbfd82951a1bb5e83e3223e25 Reviewed-on: https://chromium-review.googlesource.com/c/1270475 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597962} [modify] https://crrev.com/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a/ash/cursor_unittest.cc [modify] https://crrev.com/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a/services/ws/event_test_utils.cc [modify] https://crrev.com/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a/services/ws/window_tree.cc [modify] https://crrev.com/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a/services/ws/window_tree_unittest.cc [modify] https://crrev.com/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/515fe3da84bc4ec93c8cc2288820bbeeaa5f396a/ui/aura/mus/window_tree_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19f62b3fd22db45b42ca48dd0815b945f68b650e commit 19f62b3fd22db45b42ca48dd0815b945f68b650e Author: Scott Violet <sky@chromium.org> Date: Wed Oct 10 21:16:23 2018 window-service: makes event injection interfaces use Mouse/Touch event instead of PointerEvent. BUG= 865781 TEST=covered by tests Change-Id: Id185c17fc0005976ee02fb14be82c33ea6b916e8 Reviewed-on: https://chromium-review.googlesource.com/c/1272616 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#598509} [modify] https://crrev.com/19f62b3fd22db45b42ca48dd0815b945f68b650e/services/ws/event_injector.cc [modify] https://crrev.com/19f62b3fd22db45b42ca48dd0815b945f68b650e/ui/aura/event_injector.cc [modify] https://crrev.com/19f62b3fd22db45b42ca48dd0815b945f68b650e/ui/aura/test/event_generator_delegate_aura.cc [modify] https://crrev.com/19f62b3fd22db45b42ca48dd0815b945f68b650e/ui/aura/test/ui_controls_factory_ozone.cc [modify] https://crrev.com/19f62b3fd22db45b42ca48dd0815b945f68b650e/ui/views/mus/drag_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4310fc145ccae10b1dfb9f6c9aa284e08ad93478 commit 4310fc145ccae10b1dfb9f6c9aa284e08ad93478 Author: Mike Wasserman <msw@chromium.org> Date: Fri Oct 12 18:33:16 2018 ws: Add EventObserver interface and window service support Replaces PointerWatcher with a more generalized EventObserver. EventObserver supports local code and remote window-service clients. Ash & remote client aura::Envs host their respective EventObservers. Ash notifies local observers via a pre-target event handler adapter. WindowTreeClients forwards requested event types to WindowTree. WindowTree notifies WindowTreeClients of input and observed events. Needed to support more existing ws client pre-target event handlers. Replaces the remaining ws mouse/touch->pointer event conversions. A followup CL will rebase views::EventMonitor on EventObserver: https://chromium-review.googlesource.com/c/chromium/src/+/1258217 Bug: 887725 , 872450 , 865781 Test: No --show-taps, immersive, touch edit handle, etc. changes. Change-Id: I5ed870a3be948bf48448ed1a5e54a2bf4512e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/1269806 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599303} [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/BUILD.gn [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/ash_service_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/components/tap_visualizer/tap_renderer.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/components/tap_visualizer/tap_renderer.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/components/tap_visualizer/tap_visualizer_app.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/components/tap_visualizer/tap_visualizer_app.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/components/tap_visualizer/tap_visualizer_app_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/metrics/pointer_metrics_recorder_unittest.cc [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ash/pointer_watcher_adapter.cc [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ash/pointer_watcher_adapter.h [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ash/pointer_watcher_adapter_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/public/cpp/immersive/immersive_context.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/public/cpp/immersive/immersive_fullscreen_controller.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/public/cpp/immersive/immersive_fullscreen_controller.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/shelf/shelf_view.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/shell.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/shell.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/system/palette/palette_tray.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/wm/immersive_context_ash.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ash/wm/immersive_context_ash.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/chrome/browser/ui/views/frame/immersive_context_mus.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/chrome/browser/ui/views/frame/immersive_context_mus.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/content/renderer/mus/renderer_window_tree_client.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/BUILD.gn [add] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/event_observer_helper.cc [add] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/event_observer_helper.h [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/services/ws/pointer_watcher.cc [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/services/ws/pointer_watcher.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/public/mojom/window_tree.mojom [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/test_change_tracker.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/test_change_tracker.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/test_window_tree_client.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/test_window_tree_client.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/window_tree.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/window_tree.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/window_tree_client_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/services/ws/window_tree_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/env.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/env.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/mus/window_tree_client_delegate.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/aura_test_base.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/event_generator_delegate_aura.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/event_generator_delegate_aura.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/mus/test_window_tree.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/mus/test_window_tree_client_delegate.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/mus/test_window_tree_client_delegate.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/mus/window_tree_client_private.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/test/mus/window_tree_client_private.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/aura/window_event_dispatcher.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/events/BUILD.gn [add] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/events/event_observer.h [rename] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/events/events_exports.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/events/test/event_generator.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/events/test/event_generator.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/BUILD.gn [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/mus/BUILD.gn [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/mus/mus_client.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/mus/mus_client.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/mus/mus_views_delegate.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/mus/mus_views_delegate.h [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ui/views/mus/pointer_watcher_event_router.cc [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ui/views/mus/pointer_watcher_event_router.h [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ui/views/mus/pointer_watcher_event_router_unittest.cc [delete] https://crrev.com/a1f93ce2de4aaa5fabbaaab5aa628dca9ffccd8d/ui/views/pointer_watcher.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/touchui/touch_selection_controller_impl.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/touchui/touch_selection_controller_impl.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/views_delegate.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/views/views_delegate.h [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/wm/test/wm_test_helper.cc [modify] https://crrev.com/4310fc145ccae10b1dfb9f6c9aa284e08ad93478/ui/wm/test/wm_test_helper.h
This is now done. I will remove PointerEvent separately.
Comment 1 by bugdroid1@chromium.org
, Oct 6