Files app tablet mode: Share dialog becomes empty when onscreen keyboard is displayed |
|||||||
Issue descriptionGoogle Chrome 68.0.3440.70 (Official Build) beta (64-bit) Revision dcbf48aee0a261c062487bf346c0dbbd4f346a06-refs/branch-heads/3440@{#718} Platform 10718.58.0 (Official Build) beta-channel eve What steps will reproduce the problem? 1. Open Files app with device in tablet mode. 2. Select any file from drive and click on share icon. Click on 'Share with others' 3. Tap on the text field to start typing. 4. On screen keyboard pops up. Observe share dialog What is the expected result? Share dialog contents should be visible What happens instead? Share dialog is empty. Attached screenshot.
,
Jul 23
,
Jul 24
slangley@ - Who's the best person to take a look at this one?
,
Jul 24
,
Jul 25
Possible regression caused by crbug.com/740223
,
Jul 25
shend@ working on a fix for this relating to how virtual keyboard calculates insets.
,
Jul 25
I'll take this. That should fix the blank space issue.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5aca2e1234a8ab1ed707508042fde2ebdd2b5d2e commit 5aca2e1234a8ab1ed707508042fde2ebdd2b5d2e Author: Darren Shen <shend@chromium.org> Date: Thu Jul 26 01:47:20 2018 [VK] Use view bounds instead of window bounds for overscrolling. For overscrolling, we calculate the overlap between the virtual keyboard and the window bounds of the render widget. This doesn't work for webviews used as dialogs, as the window of a webview is the same as its parent, which has a much larger size of the actual webview. We change the overscrolling code to compute the overlap based on the webview bounds rather than window bounds. Bug: 865774 Change-Id: I26c4e87215c2c168a8dc827f6d6b6859fdb6268c Reviewed-on: https://chromium-review.googlesource.com/1150012 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#578163} [modify] https://crrev.com/5aca2e1234a8ab1ed707508042fde2ebdd2b5d2e/chrome/browser/ui/ash/chrome_keyboard_ui.cc
,
Jul 26
This should fix the blank space issue, but there are still bugs when you scroll the background page or move the dialog. I'll think more about a proper fix (e.g. scrolling both the webview and the background together).
,
Aug 21
This bug has a target milestone that has passed. Please help bug cleanup: mark it closed or update/remove the milestone target.
,
Aug 22
Moving and reprioritising since the main issue is fixed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dymp...@gmail.com
, Jul 22