virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll.html is flaky |
|||
Issue descriptionThis test has been very flaky on all dbg bots, especially Mac10.13 Tests (dbg), see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Ffast%2Fscroll-behavior%2Fsmooth-scroll%2Fmousewheel-scroll.html Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4139 Sample output: This is a testharness.js-based test. FAIL This test ensures that consecutive mouse wheel ticks diagonally scroll to the right offset. The main purpose of this test is to ensure that smooth scrolling on the compositor works as intended (tested via virtual suite virtual/threaded/). promise_test: Unhandled rejection with value: "Reaches the maximum frames." PASS This test ensures that consecutive mouse wheel ticks vertically or horizontally scroll to the right offset. The main purpose of this test is to ensure that smooth scrolling on the compositor works as intended (tested via virtual suite virtual/threaded/). Harness: the test ran to completion. sahel@: would you be able to triage this further? I'll mark it as flaky in the meantime.
,
Aug 9
This test was marked as flaky on debug, but it's flaky on non-debug platforms too: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Ffast%2Fscroll-behavior%2Fsmooth-scroll%2Fmousewheel-scroll.html I think this test may have became flaky with: https://chromium-review.googlesource.com/c/chromium/src/+/1097943
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c08bd92fe2b3db98fd2fa23b194bd1450f4bb8d8 commit c08bd92fe2b3db98fd2fa23b194bd1450f4bb8d8 Author: Sahel Sharify <sahel@chromium.org> Date: Fri Aug 10 15:28:47 2018 mousewheel-scroll.html flaky test updated. Bug: 865755 Change-Id: Ic24c1405392ba42810f516f375a3d304a81a88ed Reviewed-on: https://chromium-review.googlesource.com/1169779 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582175} [modify] https://crrev.com/c08bd92fe2b3db98fd2fa23b194bd1450f4bb8d8/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c08bd92fe2b3db98fd2fa23b194bd1450f4bb8d8/third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/mousewheel-scroll.html
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12a5a01fb962b4682fdafd8b5783d469ee2e57f2 commit 12a5a01fb962b4682fdafd8b5783d469ee2e57f2 Author: Sahel Sharify <sahel@chromium.org> Date: Wed Aug 29 16:03:22 2018 Increase approx_equals' epsilon to 4 pixels in mousewheel-scroll.html This cl is a follow up to the following cl since mousewheel-scroll.html is still flaky: https://chromium-review.googlesource.com/c/chromium/src/+/1169779 This test consists of a few smoothscroll calls per promise_test and the inaccuracy of each calls propagates to the next one and that's why we need higher epsilon values for the approximation of scrollTop/Left to make sure that the test is stable. TBR=bokan@chromium.org Bug: 865755 Change-Id: I438c285ef4502bc09450e49d38b0ae31a08594cd Reviewed-on: https://chromium-review.googlesource.com/1195161 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587135} [modify] https://crrev.com/12a5a01fb962b4682fdafd8b5783d469ee2e57f2/third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/mousewheel-scroll.html
,
Aug 29
,
Sep 12
The NextAction date has arrived: 2018-09-12
,
Sep 13
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=mousewheel-scroll.html shows that the test is still flaky specially on dbg bots. Another point is that only the threaded version of the test is flaky. I will resume working on this test once we have a systematic way to de-flake tests. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 19