New issue
Advanced search Search tips

Issue 865745 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK in gdig

Project Member Reported by wfh@chromium.org, Jul 19

Issue description

Chrome Version: 3eafc7f1009b64dfed21bac94e133e1629e1c8d3
OS: Win 10

What steps will reproduce the problem?
(1) build gdig with dcheck_always_on = true
(2) run gdig
(3)

What is the expected result?

gdig works

What happens instead?

c:\src\gclient\src>out\goma64\gdig google.com
[0719/144906.421:FATAL:post_task.cc(72)] Check failed: TaskScheduler::GetInstance(). Ref. Prerequisite section of post_task.h.

Hint: if this is in a unit test, you're likely merely missing a base::test::ScopedTaskEnvironment member in your fixture.

Backtrace:
        base::debug::StackTrace::StackTrace [0x00007FF669DFD754+36] (C:\src\gclient\src\base\debug\stack_trace_win.cc:286)
        logging::LogMessage::~LogMessage [0x00007FF669DAE432+98] (C:\src\gclient\src\base\logging.cc:593)
        base::PostDelayedTaskWithTraits [0x00007FF669DC841E+126] (C:\src\gclient\src\base\task_scheduler\post_task.cc:76)
        base::`anonymous namespace'::PostTaskAndReplyWithTraitsTaskRunner::PostTask [0x00007FF669DC8711+81] (C:\src\gclient\src\base\task_scheduler\post_task.cc:26)
        base::internal::PostTaskAndReplyImpl::PostTaskAndReply [0x00007FF669E122E5+597] (C:\src\gclient\src\base\threading\post_task_and_reply_impl.cc:119)
        base::PostTaskWithTraitsAndReply [0x00007FF669DC853E+110] (C:\src\gclient\src\base\task_scheduler\post_task.cc:87)
        net::SerialWorker::WorkNow [0x00007FF669D8D321+353] (C:\src\gclient\src\net\dns\serial_worker.cc:27)
        net::internal::DnsConfigServiceWin::ReadNow [0x00007FF669D6EE8C+28] (C:\src\gclient\src\net\dns\dns_config_service_win.cc:740)
        net::DnsConfigService::ReadConfig [0x00007FF669D6BF91+257] (C:\src\gclient\src\net\dns\dns_config_service.cc:117)
        main [0x00007FF669D630B4+4164] (c:\src\gclient\src\net\tools\gdig\gdig.cc:523)
        __scrt_common_main_seh [0x00007FF669EED308+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
        BaseThreadInitThunk [0x00007FFD17B73034+20]
        RtlUserThreadStart [0x00007FFD197D1431+33]



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
What is gdig?! Looks like it's missing a TaskScheduler instance. i.e. need to invoke base::TaskScheduler::CreateAndStartWithDefaultParams() from gdig.cc::main().
Components: -Internals>Network Internals>Network>DNS
We may just want to remove the tool - don't believe anyone on the network team is actually using it.
Owner: mmenke@chromium.org
Status: Assigned (was: Untriaged)
I'll remove the tool.  If I face pushback, I'll fix it.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4a64fc062f068af43305bb6b75a129835ec20ad

commit a4a64fc062f068af43305bb6b75a129835ec20ad
Author: Matt Menke <mmenke@chromium.org>
Date: Sat Jul 21 01:15:45 2018

Delete the gdig tool.

This was a tool to use the DNS stub resolver from the command line.

The tool has been broken for at least 10 months, since it didn't set
up a task scheduler, but used code that required one. Since no one
noticed for so long, I assume we can just remove it, and have less
code to maintain.

Bug:  865745 
Change-Id: Ia3c9e7ec5a038acaf1d1318a8aeab79192c526ae
Reviewed-on: https://chromium-review.googlesource.com/1145714
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577051}
[modify] https://crrev.com/a4a64fc062f068af43305bb6b75a129835ec20ad/BUILD.gn
[modify] https://crrev.com/a4a64fc062f068af43305bb6b75a129835ec20ad/net/BUILD.gn
[delete] https://crrev.com/6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7/net/tools/gdig/file_net_log.cc
[delete] https://crrev.com/6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7/net/tools/gdig/file_net_log.h
[delete] https://crrev.com/6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7/net/tools/gdig/gdig.cc

Status: Fixed (was: Assigned)

Sign in to add a comment