New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865733 link

Starred by 1 user
Status: Fixed
Owner:
█ jamwalla@chromium.org
Last visit > 30 days ago
Closed: Jul 26
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Move AccessibilityUI from content/ to chrome/

Project Member Reported by jamwalla@chromium.org, Jul 19 
The code for chrome://accessibility should be moved out of
chrome and into content.

Some reasons to have the code in chrome instead of content:
* We could show windows other than just web content, like
  dialogs or even ARC++ windows on Chrome OS
* We could save preferences

Comment 1 by jamwalla@chromium.org, Jul 19

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eafc94cb95e2de229e5ebdb9a2619086e7d7195e

commit eafc94cb95e2de229e5ebdb9a2619086e7d7195e
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Mon Jul 23 21:35:09 2018

Move AccessibilityUI from content/ to chrome/

Move the code for chrome://accessibility out of content/.

Bug:  865733 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4169a666cbf73f5ea9c3383d7aca44577b24193b
Reviewed-on: https://chromium-review.googlesource.com/1144187
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577273}
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/BUILD.gn
[rename] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/accessibility/accessibility_ui.cc
[rename] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/accessibility/accessibility_ui.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/browser_resources.grd
[rename] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/resources/accessibility/OWNERS
[rename] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/resources/accessibility/accessibility.css
[rename] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/resources/accessibility/accessibility.html
[rename] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/resources/accessibility/accessibility.js
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/chrome/common/webui_url_constants.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/BUILD.gn
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/accessibility/accessibility_tree_formatter.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/accessibility/accessibility_tree_formatter.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/accessibility/browser_accessibility_state_impl.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/accessibility/browser_accessibility_state_impl.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/content_resources.grd
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/public/browser/browser_accessibility_state.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/public/browser/web_contents.h
[modify] https://crrev.com/eafc94cb95e2de229e5ebdb9a2619086e7d7195e/content/public/common/url_constants.cc

Comment 3 by jamwalla@chromium.org, Jul 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment