New issue
Advanced search Search tips

Issue 865727 link

Starred by 1 user
Status: Assigned
Owner:
michaeldo@chromium.org
Cc:
eugene...@chromium.org
ios-bugs@chromium.org
ajuma@chromium.org
kkhorimoto@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----
Team-Security-UX



Sign in to add a comment

CaptivePortalDetector shows SSL interstitial without pending item

Project Member Reported by danyao@chromium.org, Jul 19 
NavigationManager::AddTransientItem() is only expected to be called when there is an active pending non-app-specific URL. This assumption seems broken by the captive portal use case in IOSSSLErrorHandler.

This causes crashes in the navigation manager. See crbug.com/854756 for WKBasedNavigationManager and crbug.com/822908 for LegacyNavigationManager.

Should navigation manager support this use case and allow transient items to be added without a pending item? 
Or should captive portal use case be implemented differently?

Comment 1 by danyao@chromium.org, Jul 19 

We should probably add tests regardless of the decision. Both navigation manager implementations have DCHECK for this case. The fact that the crash was only caught in production suggests that we don't have test coverage for this scenario.

Comment 2 by olivierrobin@chromium.org, Jul 20

Components: UI>Browser>Interstitials
Status: Assigned (was: Untriaged)

Comment 3 by eugene...@chromium.org, Oct 26

Components: Mobile>iOSWeb

Comment 4 by eugene...@chromium.org, Oct 26

Components: -Mobile>WebView>Glue
►

Sign in to add a comment