RenderTextHarfBuzzTest.HarfBuzz_BreakRunsByEmoji fails on Android |
|
Issue descriptionRenderTextHarfBuzzTest, HarfBuzz_BreakRunsByEmoji fails on Android. Early versions of macOS provide a tofu glyph for the variation selector. This probably happens on Android as well. From the error message below, it seems one extra space is used. That extra space might be for a tofu glyph. However, when I visit the following URL on Clank, there's no tofu glyph. https://www.google.com/search?q=%E2%98%8E%E2%98%8E%EF%B8%8F [ RUN ] RenderTextHarfBuzzTest.HarfBuzz_BreakRunsByEmojiVariationSelectors/HarfBuzz ../../ui/gfx/render_text_unittest.cc:4060: Failure Expected equality of these values: 2 * kGlyphWidth Which is: 60 render_text->GetUpdatedCursorBounds().x() Which is: 90 Stack trace: #00 0x8a0df547 /data/app/org.chromium.native_test-lsa3NrQmkp6b-hMSTFKYcA==/lib/x86/libbase.cr.so+0x0011b547 #01 0x87c85099 /data/app/org.chromium.native_test-lsa3NrQmkp6b-hMSTFKYcA==/lib/x86/lib_gfx_unittests__library.cr.so+0x00231099 ../../ui/gfx/render_text_unittest.cc:4064: Failure Expected equality of these values: 3 * kGlyphWidth Which is: 90 render_text->GetUpdatedCursorBounds().x() Which is: 120 Stack trace: #00 0x8a0df547 /data/app/org.chromium.native_test-lsa3NrQmkp6b-hMSTFKYcA==/lib/x86/libbase.cr.so+0x0011b547 #01 0x87c85099 /data/app/org.chromium.native_test-lsa3NrQmkp6b-hMSTFKYcA==/lib/x86/lib_gfx_unittests__library.cr.so+0x00231099 ../../ui/gfx/render_text_unittest.cc:4069: Failure Expected equality of these values: 3 * kGlyphWidth Which is: 90 render_text->GetUpdatedCursorBounds().x() Which is: 120 Stack trace: #00 0x8a0df547 /data/app/org.chromium.native_test-lsa3NrQmkp6b-hMSTFKYcA==/lib/x86/libbase.cr.so+0x0011b547 #01 0x87c85099 /data/app/org.chromium.native_test-lsa3NrQmkp6b-hMSTFKYcA==/lib/x86/lib_gfx_unittests__library.cr.so+0x00231099 [ FAILED ] RenderTextHarfBuzzTest.HarfBuzz_BreakRunsByEmojiVariationSelectors/HarfBuzz, where GetParam() = 0 (78 ms)
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22100358580bd5386491478e2fb72d1ccee1d0b8 commit 22100358580bd5386491478e2fb72d1ccee1d0b8 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Tue Jul 24 02:21:50 2018 Enable render_text_unittest on Android Some tests are disabled for now. Bug: 853281 , 865527, 865540 , 865709, 865715 Change-Id: I4fda286ff877301704426820ee10d200cd54468b Reviewed-on: https://chromium-review.googlesource.com/1144305 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577408} [modify] https://crrev.com/22100358580bd5386491478e2fb72d1ccee1d0b8/ui/gfx/BUILD.gn [modify] https://crrev.com/22100358580bd5386491478e2fb72d1ccee1d0b8/ui/gfx/render_text_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by wychen@chromium.org
, Jul 19Summary: RenderTextHarfBuzzTest.HarfBuzz_BreakRunsByEmoji fails on Android (was: RenderTextHarfBuzzTest, HarfBuzz_BreakRunsByEmoji fails on Android)