New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865688 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Jul 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-165.4% regression in memory.top_10_mobile at 1531964277:1531978873

Project Member Reported by npm@chromium.org, Jul 19

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=865688

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=49d099ed9fedb79618b1e4d2d67e984b45a8d1b5c039d2b05f70465f9b8e11f5


Bot(s) for this bug's original alert(s):

health-plan-webview-low-end-phone
perf-go-webview-phone

=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Please try rerunning the bisect.


If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: go-webview-phone-perf-bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/background/after_http_yandex_ru_touchsearch_text_science
  Change       : 165.35% | 5080405.33333 -> 13480618.6667

Revision                                       Result                   N
android-chrome@cd22f0f943                      5080405 +- 6166.71       6      good
android-chrome@cd22f0f943,chromium@576157      5079040 +- 14654.3       6      good
android-chrome@c0e3d62ff2                      13480619 +- 14520.1      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.yandex.ru.touchsearch.text.science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8940541304373621952


For feedback, file a bug with component Speed>Bisection
Cc: perezju@chromium.org
A pretty large graphics memory regression on low end devices, let's try bisecting again ...
Cc: enne@chromium.org
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author enne@chromium.org ===

Hi enne@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Adrienne Walker
  Commit : f973fceec6e8eec76f90fa30d33a9a3c13aebf24
  Date   : Wed Jul 18 20:08:24 2018
  Subject: Free fewer resources when idle in oop raster

Bisect Details
  Configuration: go-webview-phone-perf-bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/load_news/load_news_wikipedia
  Change       : 79.97% | 10186410.0 -> 18332671.3333

Revision                                       Result                  N
android-chrome@cd22f0f943                      10186410 +- 863869      6      good
android-chrome@cd22f0f943,chromium@576157      9404757 +- 15686.5      6      good
android-chrome@cd22f0f943,chromium@576174      9672362 +- 648370       6      good
android-chrome@cd22f0f943,chromium@576178      9580202 +- 436686       6      good
android-chrome@cd22f0f943,chromium@576179      9560405 +- 444348       6      good
android-chrome@cd22f0f943,chromium@576180      18245973 +- 712014      6      bad       <--
android-chrome@cd22f0f943,chromium@576182      18321066 +- 826876      6      bad
android-chrome@cd22f0f943,chromium@576190      17964031 +- 425004      6      bad
android-chrome@c0e3d62ff2                      18332671 +- 815944      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.wikipedia system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8940213458060946128


For feedback, file a bug with component Speed>Bisection
Cc: benhenry@chromium.org ushesh@chromium.org
From the CL description sounds like this increase in graphics memory is intended, but should probably double check. Note e.g. in some cases this is registering as an increase of up to 12MiB:

https://chromeperf.appspot.com/report?sid=d7533c0f46ec5036e260ec7110f71740621ed3ff391e579865a628e5f85a3bf4&rev=1531978873

+benhenry, +ushesh FYI as this shows as a large regression on the number to be reported for graphics on the M69 health plan, e.g. in:
https://chrome-health.googleplex.com/health-plan/android-webview/memory/go-phone-1024/?m=68
Mergedinto: 865617
Status: Duplicate (was: Assigned)
Yeah, 12MB is more than I would expect.  I was thinking more in the 4MB range, as is seen on issue 865617.

After some discussion with ericrk, I'm going to revert this patch.  Merging into the other bug.

Sign in to add a comment