To make things consistent, we need to pick up the changes in WPT version of audit.js.
This would be a great project "while in the airplane or train".
This is about the file in https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/webaudio/resources/. Right?
Basically make wpt/webaudio/resources/audit.js and LayoutTests/webaudio/resources/audit.js match, more or less.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02a673df348e86553b50467a7dde1afce427b713 commit 02a673df348e86553b50467a7dde1afce427b713 Author: Hongchan Choi <hongchan@chromium.org> Date: Thu Aug 30 18:07:16 2018 Fix the error catching logic of should().throw() in audit.js Context: https://github.com/web-platform-tests/wpt/pull/12606 Change the logic of should.throw() so we can handle 3 cases - should(someExpression).throw(); should(someExpression).throw(TypeError); should(someExpression).throw(DOMException, 'NotSupportedError'); The generic error (except for DOMException) can be passed without the second argument, but this change will enforce the second arg when the expected error is a DOMException type. This touches many test files, so the work will be done in several steps: 1. Change audit.js, audionodeoptions.js on both locations. (wpt, non-wpt) 2. Update affected test files with the script. 3. Update the rest of test files which can't be updated programmatically. Bug: 865614 Test: All layout tests pass. Change-Id: I16acacb26c194a0ff950aca05e931195bf55167f Reviewed-on: https://chromium-review.googlesource.com/1184146 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587660} [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/resources/audionodeoptions.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/resources/audit.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/resources/start-stop-exceptions.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-sizing.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audionode-interface/audionode.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/automation-rate.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-construction.https.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-constructor-options.https.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-basic.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-basic.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-channelmergernode-interface/ctor-channelmerger.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-channelsplitternode-interface/audiochannelsplitter.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-channelsplitternode-interface/ctor-channelsplitter.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/convolver-channels.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-delaynode-interface/delaynode-maxdelaylimit.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-basic.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-offlineaudiocontext-interface/ctor-offlineaudiocontext.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-pannernode-interface/ctor-panner.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/huge-buffer.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-value-setter-error.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/AudioParam/value-setter-warnings.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-basic.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-exceptions.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-neuter.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/event-constructor.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-close.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/resources/audionodeoptions.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/resources/audit.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/resources/set-position-vs-curve-test.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/resources/start-stop-exceptions.js [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html [modify] https://crrev.com/02a673df348e86553b50467a7dde1afce427b713/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html
This is fixed now, right?
Yeap.
Comment 1 by hongchan@chromium.org
, Jul 20Status: Assigned (was: Available)