New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865613 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Segfault when running "led get-builder"

Project Member Reported by bpastene@chromium.org, Jul 19

Issue description

When running "led get-builder" for any existing builder in luci.chromium.ci (and prob other buckets), go panics and spits out the following error:

led get-builder luci.chromium.ci:android-kitkat-arm-rel
[I 2018-07-19 12:38:12] getting builder definition
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7dba0e]

goroutine 1 [running]:
main.JobDefinitionFromNewTaskRequest(0xc4201e0000, 0x86ae80, 0xc4201e0000, 0x0)
        /tmp/_chrome_infra_build/infra/go/src/infra/tools/led/job.go:46 +0xfe
main.(*cmdGetBuilder).grabBuilderDefinition(0xc4201ac000, 0x974b40, 0xc4201cc000, 0x7fff43fcbfd4, 0x10, 0x7fff43fcbfe5, 0x16, 0x0, 0x0, 0x0, ...)
        /tmp/_chrome_infra_build/infra/go/src/infra/tools/led/cmd_get_builder.go:137 +0x574
main.(*cmdGetBuilder).Run(0xc4201ac000, 0x976060, 0xc4200ea5a0, 0xc42001c0b0, 0x1, 0x1, 0xc42001d950, 0xc420026ce8)
        /tmp/_chrome_infra_build/infra/go/src/infra/tools/led/cmd_get_builder.go:160 +0x372
github.com/maruel/subcommands.Run(0x976060, 0xc4200ea5a0, 0x0, 0x2, 0x2, 0x0)
        /tmp/_chrome_infra_build/infra/go/.vendor/src/github.com/maruel/subcommands/subcommands.go:360 +0x4b0
main.main()
        /tmp/_chrome_infra_build/infra/go/src/infra/tools/led/main.go:133 +0x525
 
Cc: khushals...@chromium.org tandrii@chromium.org
 Issue 865603  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/5deb1755347167bfe726d33e3bc94cfb81896315

commit 5deb1755347167bfe726d33e3bc94cfb81896315
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Jul 19 21:50:18 2018

[led] Roll led version to fix swarming API incompatibility.

Rolls to:
  https://chromium.googlesource.com/infra/infra/+/f1bd290f360830f99bd414e0141523c59bacd098

R=bpastene@chromium.org, martiniss@chromium.org

Bug:  865613 
Change-Id: Ia2747f2408ac57c8f617287757ae7de786376412
Reviewed-on: https://chromium-review.googlesource.com/1144279
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/5deb1755347167bfe726d33e3bc94cfb81896315/cipd_manifest.txt

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c68d40c45ae983b4db5596dd4e63daa4e405f5f

commit 6c68d40c45ae983b4db5596dd4e63daa4e405f5f
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 20 00:14:59 2018

Roll src/third_party/depot_tools 2c984a03caff..5deb17553471 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c984a03caff..5deb17553471


git log 2c984a03caff..5deb17553471 --date=short --no-merges --format='%ad %ae %s'
2018-07-19 iannucci@chromium.org [led] Roll led version to fix swarming API incompatibility.


Created with:
  gclient setdep -r src/third_party/depot_tools@5deb17553471

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:865613 
TBR=agable@chromium.org

Change-Id: Id7447e8693e3f63f429d4eebc09e8612f0c06979
Reviewed-on: https://chromium-review.googlesource.com/1144062
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576707}
[modify] https://crrev.com/6c68d40c45ae983b4db5596dd4e63daa4e405f5f/DEPS

Sign in to add a comment