raised omnibox should not be displayed in popup windows |
||||
Issue description
Chrome Version: 69.0.3496.0 (Developer Build) (64-bit)
OS: Debian Linux (probably occurs on all os's)
What steps will reproduce the problem?
(1) Open a pop up window `window.open('https://bugs.chromium.org/p/chromium/issues/detail?id=856909', '', 'status');`
(2) focus the location bar by clicking it
(3) press page up or page down
What is the expected result?
nothing should change
What happens instead?
raised omnibox is displayed
Possibly accurate helpful information:
It seems in normal windows, page up, page down, up, and down are all mapped to traverse the omnibox suggestions when the omnibox is unraised. It seems the popup window ignores the up & down keys, but not the page up & page down.
,
Jul 25
It was already existing behavior and occurs in today's stable release, so I'm not sure if it's prioritized for 69 for some later release.
,
Aug 29
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e12ac758f2940eee68fa0be7f12103ddc1a5f0be commit e12ac758f2940eee68fa0be7f12103ddc1a5f0be Author: manuk <manukh@chromium.org> Date: Wed Aug 29 20:48:58 2018 [Omnibox] Prevent displaying popup results when page up or down keys are pressed in a popup window. Bug: 865611 Change-Id: I8f527872ea1916ea326c1e44e3d6fd1361eab3f6 Reviewed-on: https://chromium-review.googlesource.com/1195810 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#587291} [modify] https://crrev.com/e12ac758f2940eee68fa0be7f12103ddc1a5f0be/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Aug 29
,
Aug 30
Tried to test the issue on reported chrome 69.0.3496.0 using Ubuntu 17.10, build without fix. Steps: ------ 1. Launched reported chrome 2. Enabled flag #top-chrome-md to touchable-refresh (as per comment #0 attached issue) 3. Opened popup and focused on location bar>> pressed page up/ page down As we are observed that nothing change in the location bar. Attached is the screenshot for reference. manukh@: Could you please review the attached screenshot and and help us in verifying the fix. Thanks..!
,
Aug 30
it's working in the ur c#6 video. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tommycli@chromium.org
, Jul 25Owner: manukh@chromium.org
Status: Assigned (was: Untriaged)