New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove //courgette from android builds (25kb)

Project Member Reported by agrieve@chromium.org, Jul 19

Issue description

According to a supersize dump, //courgette is being linked into libchrome, but afaik it is not used on Android.

We should investigate why it's being linked in and see if we can remove it.
 
Cc: jcivelli@chromium.org
chrome/utility/chrome_content_utility_client.cc + the PatchService is why. I don't think it's used.

jcivelli: added the patching service. Cna I remove it?
https://chromium-review.googlesource.com/c/chromium/src/+/1144206
Owner: yfried...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23

commit ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23
Author: Yaron Friedman <yfriedman@chromium.org>
Date: Fri Jul 20 15:06:30 2018

Don't link courgette into chrome on Android.

Removes the PatchService from the Utility Process for Android as it's unused
but pulls in Courgette. Compiling this out saves at least 25kb.

Bug:  865593 
Change-Id: I86f3e72bba02b16af912a1855fbc6118433759a9
Reviewed-on: https://chromium-review.googlesource.com/1144206
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576864}
[modify] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/chrome/browser/BUILD.gn
[modify] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/chrome/utility/BUILD.gn
[modify] https://crrev.com/ac8bf3cd3e37abc44dd515c5c0005b153a2c0b23/chrome/utility/chrome_content_utility_client.cc

Status: Fixed (was: Started)

Sign in to add a comment