New issue
Advanced search Search tips

Issue 865578 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT] New failures introduced in external/wpt/webaudio by import https://crrev.com/c/1142744

Project Member Reported by robertma@chromium.org, Jul 19

Issue description

WPT import https://crrev.com/c/1142744 introduced new failures in external/wpt/webaudio:


List of new failures:

external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values-expected.txt
external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt
external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining-expected.txt
external/wpt/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic-expected.txt
[ Mac-mac10.11 ] external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt
[ Mac-retina ] external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt
[ Mac ] external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/platform/mac/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt
[ Win ] external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html new failing tests: https://crrev.com/c/1142744/4/third_party/WebKit/LayoutTests/platform/win/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt


This import contains upstream changes from 70afecf33059eab74cd92d97822386955e905a10 to e26d876c1d00674a9f6b8f29f6fb32a794cd536e:
Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/8dab948a10f073a46f13f55f94d1f6514c7360ac . (#12064): https://github.com/web-platform-tests/wpt/commit/e26d876c1d00674a9f6b8f29f6fb32a794cd536e
Reland "Adjusted references in tests to match new helper.sub.js file": https://github.com/web-platform-tests/wpt/commit/81d058b07f1dacf0445eb4bd20a7df14f8961185
SecurityPolicyViolationEvent.blockedURI should contain the original URL in case of redirects: https://github.com/web-platform-tests/wpt/commit/50ff428b9c1e5a93bf910190ef226283389f1004
Disable kerning for css/css-pseudo/first-letter-opacity-float-001.html: https://github.com/web-platform-tests/wpt/commit/73160366b3f95a16226623ad26285cad8c1718ae
Update the web-platform-tests for the Web Audio API to expect the right kind of type error.: https://github.com/web-platform-tests/wpt/commit/1a193d9759be413776fe215dc4167c0923d5e83b [affecting this directory]
Update web-platform-test's audit.js file throw() method to be able to pass in exactly the error or exception to expect.: https://github.com/web-platform-tests/wpt/commit/93e946525ec8a87e973aa3fb867ab0b908aaaa6c [affecting this directory]
Explicitely label the assertions for DelayNode.delayTime tests, and test the error type.: https://github.com/web-platform-tests/wpt/commit/2a5f1e56099f5808efb65a7af0c89849233d3d92 [affecting this directory]


(Manually filing because of  issue 865385 )
 
The fragmentation of baselines for external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html was partly due to an outage of the Mac Retina bot yesterday. I'll take a look and see if they can be merged.
Owner: rtoy@chromium.org
Status: Started (was: Untriaged)
I think I know the issue (same as  issue 865371 ).  Firefox changed the method should.throw() to accept an error object instead of a string.  I think they forgot to change all of the places that still used a string instead of the object.

I'll try to fix these shortly.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ccd64455e5a0a05c21732b3c8bb4f52db5df59b

commit 7ccd64455e5a0a05c21732b3c8bb4f52db5df59b
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Jul 19 21:20:18 2018

Use RangeError object instead of 'RangeError'

Remove expected results too.

Bug:  865578 
Test: affected tests pass
Change-Id: I897f7d01d7dbcd7d7316457db1ce2e307cee88ed
Reviewed-on: https://chromium-review.googlesource.com/1144139
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576635}
[modify] https://crrev.com/7ccd64455e5a0a05c21732b3c8bb4f52db5df59b/third_party/WebKit/LayoutTests/external/wpt/webaudio/resources/start-stop-exceptions.js
[delete] https://crrev.com/14dd9087c37189370b08599a2c8bfee34145d248/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt
[modify] https://crrev.com/7ccd64455e5a0a05c21732b3c8bb4f52db5df59b/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic.html
[delete] https://crrev.com/14dd9087c37189370b08599a2c8bfee34145d248/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values-expected.txt
[modify] https://crrev.com/7ccd64455e5a0a05c21732b3c8bb4f52db5df59b/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-exceptional-values.html
[delete] https://crrev.com/14dd9087c37189370b08599a2c8bfee34145d248/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining-expected.txt
[modify] https://crrev.com/7ccd64455e5a0a05c21732b3c8bb4f52db5df59b/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/audioparam-method-chaining.html
[delete] https://crrev.com/14dd9087c37189370b08599a2c8bfee34145d248/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic-expected.txt

Owner: robertma@chromium.org
Status: Assigned (was: Started)
Reassign to robertma to triage the remaining issues. ( Issue 865371  has a CL ready to go.)
Status: Fixed (was: Assigned)
Actually I think all the new errors reported in this issue have been fixed by the CL in #3 and  https://crbug.com/865371#c3  

Thanks!

Sign in to add a comment