New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: ----


Sign in to add a comment
link

Issue 865565: Implement Portals

Reported by lfg@chromium.org, Jul 19 2018 Project Member

Issue description

Comment 1 by lfg@chromium.org, Jul 19 2018

Description: Show this description

Comment 2 by lfg@chromium.org, Jul 19 2018

Description: Show this description

Comment 3 by bugdroid1@chromium.org, Jul 26 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7265507756f24d7d545e8dd157cca1dea3bc894c

commit 7265507756f24d7d545e8dd157cca1dea3bc894c
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jul 26 22:34:33 2018

Portals: Add mojo interface.

This CL just adds an empty mojo interface that will be used for
implementing portals. The interface will be exposed by the browser in a
follow-up CL.

Bug: 865565
Change-Id: I1cd93aa19f83562b5f9dccfe3eb75c93433e6770
Reviewed-on: https://chromium-review.googlesource.com/1144054
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578466}
[modify] https://crrev.com/7265507756f24d7d545e8dd157cca1dea3bc894c/third_party/blink/common/features.cc
[modify] https://crrev.com/7265507756f24d7d545e8dd157cca1dea3bc894c/third_party/blink/public/common/features.h
[modify] https://crrev.com/7265507756f24d7d545e8dd157cca1dea3bc894c/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/7265507756f24d7d545e8dd157cca1dea3bc894c/third_party/blink/public/mojom/portal/OWNERS
[add] https://crrev.com/7265507756f24d7d545e8dd157cca1dea3bc894c/third_party/blink/public/mojom/portal/portal.mojom

Comment 4 by bugdroid1@chromium.org, Aug 13

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d9c8f579509a28f9031560a124d8b382d26c54e

commit 6d9c8f579509a28f9031560a124d8b382d26c54e
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Aug 16 18:32:25 2018

Portals: Add HTMLPortalElement.

This CL adds an HTMLPortalElement to represent portals, and creates a mojo
connection to the browser-exposed interface when the element is attached
to the document.

Bug: 865565
Change-Id: Ib4e8053969d3e7ec138db84aae211b9a97a19b3c
Reviewed-on: https://chromium-review.googlesource.com/1167111
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583752}
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/content/child/runtime_features.cc
[add] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/WebKit/LayoutTests/portals/portals-api.html
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/core/html/BUILD.gn
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/core/html/html_tag_names.json5
[add] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[add] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/core/html/portal/html_portal_element.h
[add] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/core/html/portal/html_portal_element.idl
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/6d9c8f579509a28f9031560a124d8b382d26c54e/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 6 by bugdroid1@chromium.org, Aug 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a5bafd8acc36237dab02b86a03f681ad484df8

commit 98a5bafd8acc36237dab02b86a03f681ad484df8
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Aug 22 18:28:16 2018

Portals: Create the portal WebContents.

This CL adds a mojo interface to initialize the portal which creates
a WebContents on the browser process.

Bug: 865565
Change-Id: Ib28d2a720ab02e9d41f44e2b5a36d5248a248c11
Reviewed-on: https://chromium-review.googlesource.com/1178574
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585174}
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/content/browser/portal/portal.cc
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/content/browser/portal/portal.h
[add] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/content/browser/portal/portal_browsertest.cc
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/content/test/BUILD.gn
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/third_party/blink/public/mojom/portal/portal.mojom
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/98a5bafd8acc36237dab02b86a03f681ad484df8/third_party/blink/renderer/core/html/portal/html_portal_element.h

Comment 7 by bugdroid1@chromium.org, Aug 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d26aae54805ddff6e244d27bb1e25078d1d5b15

commit 5d26aae54805ddff6e244d27bb1e25078d1d5b15
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Aug 29 16:37:56 2018

Portals: Navigate the portal when the src attribute changes.

Bug: 865565
Change-Id: I13eb0ff3798c75705c8e6e5f0420722c4205787f
Reviewed-on: https://chromium-review.googlesource.com/1185533
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587151}
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/content/browser/portal/portal.cc
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/content/browser/portal/portal.h
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/content/browser/portal/portal_browsertest.cc
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/third_party/blink/public/mojom/portal/portal.mojom
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/5d26aae54805ddff6e244d27bb1e25078d1d5b15/third_party/blink/renderer/core/html/portal/html_portal_element.idl

Comment 8 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e289a91eb066d9290fb42a4b5968bf622ab22084

commit e289a91eb066d9290fb42a4b5968bf622ab22084
Author: Lucas Gadani <lfg@chromium.org>
Date: Wed Sep 19 18:54:43 2018

Portals: Attach TabHelpers when a Portal is created.

This CL adds a notification via WebContentsDelegate that
notifies the embedder that a new portal WebContents was created.

The chrome/ embedder then uses this notification in order to
attach TabHelpers to the newly created WebContents.

Bug: 865565

Change-Id: I3e39883a5869832e6e59be9db7ea9e88ab18cd64
Reviewed-on: https://chromium-review.googlesource.com/1197143
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592498}
[modify] https://crrev.com/e289a91eb066d9290fb42a4b5968bf622ab22084/chrome/browser/ui/browser.cc
[modify] https://crrev.com/e289a91eb066d9290fb42a4b5968bf622ab22084/chrome/browser/ui/browser.h
[modify] https://crrev.com/e289a91eb066d9290fb42a4b5968bf622ab22084/content/browser/portal/portal.cc
[modify] https://crrev.com/e289a91eb066d9290fb42a4b5968bf622ab22084/content/public/browser/web_contents_delegate.h

Comment 9 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/831290e17ad0fccc4af70516218bf35833d88ac7

commit 831290e17ad0fccc4af70516218bf35833d88ac7
Author: Lucas Gadani <lfg@chromium.org>
Date: Wed Oct 03 23:43:50 2018

Portals: Support activating a portal.

When a portal is activated, the portal contents replace the tab contents.

Bug: 865565
Change-Id: Id666e94b0c98294dbc2eb1ce942101a2f158ebf3
Reviewed-on: https://chromium-review.googlesource.com/c/1188884
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596428}
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/android/tab_android.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/android/tab_web_contents_delegate_android.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/sessions/session_restore_android.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/ui/browser.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/ui/browser.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/ui/tab_contents/core_tab_helper_delegate.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/chrome/browser/ui/tab_contents/core_tab_helper_delegate.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/browser/portal/portal.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/browser/portal/portal.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/browser/portal/portal_browsertest.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/shell/browser/shell.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/content/shell/browser/shell.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/third_party/blink/public/mojom/portal/portal.mojom
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/third_party/blink/renderer/core/html/portal/html_portal_element.idl
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/ui/views/controls/webview/webview.cc
[modify] https://crrev.com/831290e17ad0fccc4af70516218bf35833d88ac7/ui/views/controls/webview/webview.h

Comment 10 by bugdroid1@chromium.org, Oct 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc04085e316700aa2260e864a739a40d3532a61f

commit bc04085e316700aa2260e864a739a40d3532a61f
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Oct 04 11:47:13 2018

Revert "Portals: Support activating a portal."

This reverts commit 831290e17ad0fccc4af70516218bf35833d88ac7.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 596428 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODMxMjkwZTE3YWQwZmNjYzRhZjcwNTE2MjE4YmYzNTgzM2Q4OGFjNww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14218

Sample Failed Step: viz_content_browsertests

Sample Flaky Test: PortalBrowserTest.ActivatePortalInShell

Original change's description:
> Portals: Support activating a portal.
> 
> When a portal is activated, the portal contents replace the tab contents.
> 
> Bug: 865565
> Change-Id: Id666e94b0c98294dbc2eb1ce942101a2f158ebf3
> Reviewed-on: https://chromium-review.googlesource.com/c/1188884
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596428}

Change-Id: I8700b1340612578081c2b3ccd12a57ff48f0fd84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865565,  892004 
Reviewed-on: https://chromium-review.googlesource.com/c/1261595
Cr-Commit-Position: refs/heads/master@{#596601}
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_android.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_web_contents_delegate_android.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/sessions/session_restore_android.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/browser.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/browser.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/tab_contents/core_tab_helper_delegate.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/tab_contents/core_tab_helper_delegate.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/browser/portal/portal.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/browser/portal/portal.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/browser/portal/portal_browsertest.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/shell/browser/shell.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/shell/browser/shell.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/public/mojom/portal/portal.mojom
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/renderer/core/html/portal/html_portal_element.idl
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/ui/views/controls/webview/webview.cc
[modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/ui/views/controls/webview/webview.h

Comment 11 by bugdroid1@chromium.org, Oct 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c0cd0564ced34397f586d0d0527c3c9e742fc8

commit c5c0cd0564ced34397f586d0d0527c3c9e742fc8
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Oct 04 20:32:33 2018

Reland "Portals: Support activating a portal."

This is a reland of 831290e17ad0fccc4af70516218bf35833d88ac7

Original change's description:
> Portals: Support activating a portal.
>
> When a portal is activated, the portal contents replace the tab contents.
>
> Bug: 865565
> Change-Id: Id666e94b0c98294dbc2eb1ce942101a2f158ebf3
> Reviewed-on: https://chromium-review.googlesource.com/c/1188884
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596428}

Tbr: avi@chromium.org,jbroman@chromium.org,yfriedman@chromium.org
No-Presubmit: true

Bug: 865565
Change-Id: I0df13476e8e95a035897f38884123019150cd7b8
Reviewed-on: https://chromium-review.googlesource.com/c/1262090
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596834}
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/android/tab_android.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/android/tab_web_contents_delegate_android.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/sessions/session_restore_android.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/ui/browser.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/ui/browser.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/ui/tab_contents/core_tab_helper_delegate.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/chrome/browser/ui/tab_contents/core_tab_helper_delegate.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/browser/portal/portal.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/browser/portal/portal.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/browser/portal/portal_browsertest.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/shell/browser/shell.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/content/shell/browser/shell.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/third_party/blink/public/mojom/portal/portal.mojom
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/third_party/blink/renderer/core/html/portal/html_portal_element.idl
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/ui/views/controls/webview/webview.cc
[modify] https://crrev.com/c5c0cd0564ced34397f586d0d0527c3c9e742fc8/ui/views/controls/webview/webview.h

Comment 13 by lfg@chromium.org, Dec 11

Components: -Blink>HTML Blink>HTML>Portal

Comment 14 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61375002f412e97c5aa08db1d484d3357110cac8

commit 61375002f412e97c5aa08db1d484d3357110cac8
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Tue Dec 11 21:43:44 2018

Update HTMLPortalElement spec link in idl.

Bug: 865565
Change-Id: Ie76202a74a8d9a31884a04de88c99395800d6b5a
Reviewed-on: https://chromium-review.googlesource.com/c/1372274
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615672}
[modify] https://crrev.com/61375002f412e97c5aa08db1d484d3357110cac8/third_party/blink/renderer/core/html/portal/html_portal_element.idl

Comment 15 by jbroman@chromium.org, Dec 12

Blockedon: 914376

Comment 16 by jbroman@chromium.org, Dec 12

Blockedon: 914378

Comment 18 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/991258287fdf852c2e9d11db0471133ba4f1f6ed

commit 991258287fdf852c2e9d11db0471133ba4f1f6ed
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jan 03 15:41:49 2019

Portals: Set up a RenderFrameProxy for the portal.

The RenderFrameProxy will be used for rendering the portal in a future CL.

Bug: 865565

Change-Id: I8a14881da3d26716b2564607fb3582d7b3a1f065
Reviewed-on: https://chromium-review.googlesource.com/c/1280279
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619645}
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/frame_host/frame_tree.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/frame_host/frame_tree.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/portal/portal.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/portal/portal.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/portal/portal_browsertest.cc
[delete] https://crrev.com/357909fe63f449e025b97561d3143bb19d1d2b7b/content/browser/portal/portal_unit_test.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/common/frame.mojom
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/public/browser/web_contents.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/renderer/render_frame_impl.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/test/BUILD.gn
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/content/test/test_render_frame.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/public/mojom/portal/portal.mojom
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/html/portal/html_portal_element.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/html/portal/html_portal_element.h
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/991258287fdf852c2e9d11db0471133ba4f1f6ed/third_party/blink/renderer/core/loader/empty_clients.h

Comment 19 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f3dc7c8feabe319e7736c4739f0d651b57b7b56

commit 3f3dc7c8feabe319e7736c4739f0d651b57b7b56
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Jan 03 22:16:10 2019

Portals: Do not track attached portals as UI Tab.

Bug: 865565
Change-Id: I99af8effad00a802a9d122c3190bbbd841220f53
Reviewed-on: https://chromium-review.googlesource.com/c/1318400
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619781}
[modify] https://crrev.com/3f3dc7c8feabe319e7736c4739f0d651b57b7b56/chrome/browser/resource_coordinator/tab_load_tracker.cc

Comment 20 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment