New issue
Advanced search Search tips

Issue 865557 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Jul 20
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

MacViewsBrowser: Task Manager is views and shouldn't be

Project Member Reported by rsesek@chromium.org, Jul 19 
Chrome Version: 69.0.3496.0
OS: macOS 10.13.6

What steps will reproduce the problem?
(1) Run Canary where MacViewsBrowser is the default
(2) App Menu > More Tools > Task Manager
(3) Look at the result

What is the expected result?
Cocoa task manager, because the Views one is pretty ugly.

What happens instead?
The ugly views task manager.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Screen Shot 2018-07-19 at 1.58.24 PM.png
91.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4242f8465e8d044f9b876aba398b85b5e6d0dd3

commit c4242f8465e8d044f9b876aba398b85b5e6d0dd3
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Jul 19 19:41:56 2018

macviews: use cocoa task manager

The Views task manager is not ready to go yet.

Bug:  865557 
Change-Id: Ie6fbb6aa52baf5825e5b8025dd31ae2f40ac458f
Reviewed-on: https://chromium-review.googlesource.com/1144135
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576592}
[modify] https://crrev.com/c4242f8465e8d044f9b876aba398b85b5e6d0dd3/chrome/browser/ui/cocoa/task_manager_mac.mm

Comment 2 by susan.boorgula@chromium.org, Jul 20

Labels: TE-Verified-M69 TE-Verified-69.0.3497.0
Able to reproduce this issue on Mac OS 10.13.3 on the reported version 69.0.3496.0 and the issue is fixed on the latest Canary 69.0.3497.0 as per the original comment.

Can see the Cocoa Task manager on the latest Canary 69.0.3497.0.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
865557-M69.png
149 KB View Download

Comment 3 by ellyjo...@chromium.org, Jul 20

Status: Fixed (was: Assigned)
Project Member

Comment 4 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jul 20

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.

Comment 5 by ellyjo...@chromium.org, Jul 20

Labels: -Merge-TBD
The CL made it into 69.0.3497.0 (per #2) so -Merge-TBD.
►

Sign in to add a comment